fix: failed checks

Refs #137

R/RunModel_Lag.R

@@ -22,19 +22,19 @@ RunModel_Lag <- function(InputsModel, RunOptions, Param, QcontribDown) {
       stop("'QcontribDown' should contain a key 'Qsim' containing the output of the runoff of the downstream subcatchment")
     }
     if (length(QcontribDown$Qsim) != length(RunOptions$IndPeriod_Run)) {
-      stop("Time series Qsim in 'QcontribDown' should have the same lenght as 'RunOptions$IndPeriod_Run'")
+      stop("Time series Qsim in 'QcontribDown' should have the same length as 'RunOptions$IndPeriod_Run'")
     }
-    if (!identical(RunOptions$IndPeriod_WarmUp, 0L) && RunOptions$Outputs_Sim != RunOptions$Outputs_Cal) {
+    if (!identical(RunOptions$IndPeriod_WarmUp, 0L) && !identical(RunOptions$Outputs_Sim, RunOptions$Outputs_Cal)) {
       # This test is not necessary during calibration but usefull in other cases because
       # WarmUpQsim is then used for downstream sub-basins because of the delay in Qupstream
       if (is.null(QcontribDown$RunOptions$WarmUpQsim) ||
           length(QcontribDown$RunOptions$WarmUpQsim) != length(RunOptions$IndPeriod_WarmUp)) {
-        stop("Time series WarmUpQsim in 'QcontribDown' should have the same lenght as 'RunOptions$IndPeriod_WarmUp'")
+        stop("Time series WarmUpQsim in 'QcontribDown' should have the same length as 'RunOptions$IndPeriod_WarmUp'")
       }
     }
   } else if (is.vector(QcontribDown) && is.numeric(QcontribDown)) {
     if (length(QcontribDown) != length(RunOptions$IndPeriod_Run)) {
-      stop("'QcontribDown' should have the same lenght as 'RunOptions$IndPeriod_Run'")
+      stop("'QcontribDown' should have the same length as 'RunOptions$IndPeriod_Run'")
     }
   } else {
     stop("'QcontribDown' must be a numeric vector or a 'OutputsModel' object")

tests/testthat/test-RunModel_Lag.R

@@ -72,12 +72,12 @@ test_that("QcontribDown should contain a Qsim key", {
   )
 })
 
-test_that("'QcontribDown$Qim' should have the same lenght as 'RunOptions$IndPeriod_Run'", {
+test_that("'QcontribDown$Qim' should have the same length as 'RunOptions$IndPeriod_Run'", {
   QcontribDown <- OutputsGR4JOnly
   QcontribDown$Qsim <- c(QcontribDown$Qsim, 0)
   expect_error(
     RunModel_Lag(InputsModel = InputsModel, RunOptions = RunOptions, Param = 1, QcontribDown = QcontribDown),
-    regexp = "should have the same lenght as"
+    regexp = "should have the same length as"
   )
 })