airGR issueshttps://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues2023-02-14T13:02:13+01:00https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/170Move the project in the airGRgalaxy repository2023-02-14T13:02:13+01:00Delaigue OlivierMove the project in the airGRgalaxy repository- [ ] Move the project into the [airGRgalaxy group](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy)
- [ ] Update the **URL** and **BugReports** items in the DESCRIPTION file- [ ] Move the project into the [airGRgalaxy group](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy)
- [ ] Update the **URL** and **BugReports** items in the DESCRIPTION filev1.8https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/158Improve description of the StartParamList and StartParamDistrib arguments in ...2022-07-18T17:38:40+02:00Thirel GuillaumeImprove description of the StartParamList and StartParamDistrib arguments in CreateCalibOptionsFrom the `CreateCalibOptions` help, the distinction between `StartParamList` and `StartParamDistrib` is not clear.
I suggest adding at the end of the description of `StartParamList `the following:
> Each of the n parameter sets provid...From the `CreateCalibOptions` help, the distinction between `StartParamList` and `StartParamDistrib` is not clear.
I suggest adding at the end of the description of `StartParamList `the following:
> Each of the n parameter sets provided will be tested in a row.
I suggest adding at the end of the description of `StartParamList` the following:
> Each possible combination of parameter values will be tested in a row.v1.8https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/141Vignette about CemaNeige hysteresis to complete2022-02-21T11:13:52+01:00Thirel GuillaumeVignette about CemaNeige hysteresis to completeAs explained in Riboust et al. (2019)'s paper, the CemaNeige hysteresis must be used with a MeanAnSolidPrecip argument of CreateRunOptions set to different values for each elevation zone. As a consequence, we must add/modify a couple of ...As explained in Riboust et al. (2019)'s paper, the CemaNeige hysteresis must be used with a MeanAnSolidPrecip argument of CreateRunOptions set to different values for each elevation zone. As a consequence, we must add/modify a couple of things in the vignette showing how to use it, as well as in the example of RunModel_CemaNeigeGR4J.
In the vignette:
```r
SolidPrecip_Cal <- rep(0, 5)
SolidPrecip_Val <- rep(0, 5)
for(iLayer in 1:5){
SolidPrecip_Cal[iLayer] <- mean(InputsModel$LayerFracSolidPrecip[[iLayer]][Ind_Cal]*InputsModel$LayerPrecip[[iLayer]][Ind_Cal]);
SolidPrecip_Val[iLayer] <- mean(InputsModel$LayerFracSolidPrecip[[iLayer]][Ind_Val]*InputsModel$LayerPrecip[[iLayer]][Ind_Val]);
}
if(inherits(InputsModel,"hourly" )){ Factor <- 365.25*24; }
if(inherits(InputsModel,"daily" )){ Factor <- 365.25; }
if(inherits(InputsModel,"monthly")){ Factor <- 12; }
if(inherits(InputsModel,"yearly" )){ Factor <- 1; }
SolidPrecip_Cal <- SolidPrecip_Cal*Factor
SolidPrecip_Val <- SolidPrecip_Val*Factor
## preparation of RunOptions object
RunOptions_Cal <- CreateRunOptions(FUN_MOD = RunModel_CemaNeigeGR4J,
InputsModel = InputsModel, IndPeriod_Run = Ind_Cal, IsHyst = TRUE,
MeanAnSolidPrecip = SolidPrecip_Cal)
## preparation of RunOptions object
RunOptions_Val <- CreateRunOptions(FUN_MOD = RunModel_CemaNeigeGR4J,
InputsModel = InputsModel, IndPeriod_Run = Ind_Val, IsHyst = TRUE,
MeanAnSolidPrecip = SolidPrecip_Val)
```
In the example:
```r
SolidPrecip <- rep(0, 5)
for(iLayer in 1:5){
SolidPrecip[iLayer] <- mean(InputsModel$LayerFracSolidPrecip[[iLayer]][Ind_Run]*InputsModel$LayerPrecip[[iLayer]][Ind_Run]);
}
if(inherits(InputsModel,"hourly" )){ Factor <- 365.25*24; }
if(inherits(InputsModel,"daily" )){ Factor <- 365.25; }
if(inherits(InputsModel,"monthly")){ Factor <- 12; }
if(inherits(InputsModel,"yearly" )){ Factor <- 1; }
SolidPrecip <- SolidPrecip*Factor
## preparation of the RunOptions object
RunOptions <- CreateRunOptions(FUN_MOD = RunModel_CemaNeigeGR4J, InputsModel = InputsModel,
IndPeriod_Run = Ind_Run, IsHyst = TRUE, MeanAnSolidPrecip = SolidPrecip)
```
@olivier.delaigue, please make it R beautiful. :D
I'm doing some tests and confirm tomorrow.
Thanks @francois.bourgin for spotting that.v1.8https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/72Add a CONTRIBUTING.md file to the repository2022-02-11T18:28:14+01:00Dorchies DavidAdd a CONTRIBUTING.md file to the repositoryAs several developers work on airGR, it would be a good idea to write development directives in an unified file.
Open source projects use a file named `CONTRIBUTING.md` which include these useful information.
For details about the conte...As several developers work on airGR, it would be a good idea to write development directives in an unified file.
Open source projects use a file named `CONTRIBUTING.md` which include these useful information.
For details about the content of such a file, please have a look to: https://mozillascience.github.io/working-open-workshop/contributing/
It would be great to write some important information such as:
* the workflow: the reporter create a ticket, the developper create a branch and a merge request and work on this branch, the manager merge the branch when the job is done
* the syntax of the commit comments and the policy for versioning with how to fill the files `DESCRIPTION` and `NEWS.md`
* the code syntax: "Capital CamelCase" for variables and functions, 2 spaces tabs, max line length, brackets on `if` statements...
* the testing environment: how to test the package locally and how it is tested by Gitlab-CI
* the release procedure: how to publish the package on CRAN?https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/58T gradient in DataAltiExtrapolation_Valery only valid in Northern hemisphere2021-01-11T12:02:48+01:00Thirel GuillaumeT gradient in DataAltiExtrapolation_Valery only valid in Northern hemisphereI suspect that the DataAltiExtrapolation_Valery T gradient defined in GradT_Valery2010() is only valid for the Northern hemisphere.I suspect that the DataAltiExtrapolation_Valery T gradient defined in GradT_Valery2010() is only valid for the Northern hemisphere.v2.0https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/46Add vignette about airGRmaps2022-07-18T17:40:11+02:00Delaigue OlivierAdd vignette about airGRmapsIt is probably interesting to write a vignette about the parameter maps of the GR4J, GR5J and GR6J models. These maps are available on the [airGRmaps](https://sunshine.irstea.fr/app/airGRmaps) shiny app. May be it could be mixed in the v...It is probably interesting to write a vignette about the parameter maps of the GR4J, GR5J and GR6J models. These maps are available on the [airGRmaps](https://sunshine.irstea.fr/app/airGRmaps) shiny app. May be it could be mixed in the vignette whose title is *Generalist parameter sets for the GR4J model*.v2.0https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/44Add an example using the BoolCrit argument of CreateInputsCrit2021-01-11T12:02:23+01:00Delaigue OlivierAdd an example using the BoolCrit argument of CreateInputsCritAdd an example using the `BoolCrit` argument of the `CreateInputsCrit()` function could be a good idea.
The difference with the `IndPeriod_Run` argument of the `CreateRunOptions()` function is not very intuitive for users.
This is parti...Add an example using the `BoolCrit` argument of the `CreateInputsCrit()` function could be a good idea.
The difference with the `IndPeriod_Run` argument of the `CreateRunOptions()` function is not very intuitive for users.
This is particularly interesting for calibration above or below a flow threshold, for certain months of the year only, etc.
We should put this example in a help page or a vignette.v2.0https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/26CreateRunOptions when IniStates is given and IndPeriod_WarmUp is not = 0L2020-02-12T10:16:29+01:00Thirel GuillaumeCreateRunOptions when IniStates is given and IndPeriod_WarmUp is not = 0L(transfer from remaining issue of ticket https://forge.irstea.fr/issues/5422)
It says that when IniStates is given and IndPeriod_WarmUp is not = 0L in CreateRunOptions, the initial state is used at the beginning of the warmup period. The...(transfer from remaining issue of ticket https://forge.irstea.fr/issues/5422)
It says that when IniStates is given and IndPeriod_WarmUp is not = 0L in CreateRunOptions, the initial state is used at the beginning of the warmup period. Therefore we should improve the DOC.
Check this happens really like this and proceed.https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/24Merge documentation of Calibration and Calibration_Michel2020-05-26T11:29:27+02:00Thirel GuillaumeMerge documentation of Calibration and Calibration_Michel(transfer from ticket https://forge.irstea.fr/issues/5531)
Suggestion to merge the documentation of the two functions `Calibration` and `Calibration_Michel`.
It could be possible to define two "uses" in the doc page and to merge the ex...(transfer from ticket https://forge.irstea.fr/issues/5531)
Suggestion to merge the documentation of the two functions `Calibration` and `Calibration_Michel`.
It could be possible to define two "uses" in the doc page and to merge the examples.https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/9Add scheme of CemaNeige in the function doc2021-01-12T13:57:18+01:00Thirel GuillaumeAdd scheme of CemaNeige in the function docWe have to add the scheme of the CemaNeige model in the `RunModel_CemaNeige` function.We have to add the scheme of the CemaNeige model in the `RunModel_CemaNeige` function.