airGR issues
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues
2021-01-27T13:40:43+01:00
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/95
Move CemaNeige daily gradients outside DataAltiExtrapolation_Valery
2021-01-27T13:40:43+01:00
Delaigue Olivier
Move CemaNeige daily gradients outside DataAltiExtrapolation_Valery
Move `GradT_Valery2010()` in an utils file, outside `DataAltiExtrapolation_Valery()` in order to make it more readable.
In additon, set `GradP_Valery2010` as a vector and `GradT_Valery2010` as a data.frame instead of functions.
Rename ...
Move `GradT_Valery2010()` in an utils file, outside `DataAltiExtrapolation_Valery()` in order to make it more readable.
In additon, set `GradP_Valery2010` as a vector and `GradT_Valery2010` as a data.frame instead of functions.
Rename `GradT_Valery2010` into `.GradT_Valery2010`.
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/90
Fix incorrect parameter transformation for X5 in GR5J
2021-04-20T21:26:56+02:00
Pelletier Antoine
Fix incorrect parameter transformation for X5 in GR5J
In `TransfoParam_GR5J.R`, the proposed transformation for X5 only allows values between 0 and 1. Indeed, with `ParamOut[, 5] <- (ParamIn[, 5] + 9.99) / 19.98`, with `ParamIn[, 5]` between -9.99 and 9.99, we get bounds of 0 and 1.
Yet, X...
In `TransfoParam_GR5J.R`, the proposed transformation for X5 only allows values between 0 and 1. Indeed, with `ParamOut[, 5] <- (ParamIn[, 5] + 9.99) / 19.98`, with `ParamIn[, 5]` between -9.99 and 9.99, we get bounds of 0 and 1.
Yet, X5 can take values below 0 and above 1 (see figure 8 of [this article](https://doi.org/10.1016/j.jhydrol.2011.09.034) for instance). The proposed transformation in `TransfoParam_GR6J.R`, which is `ParamOut[, 5] <- ParamIn[, 5] / 5`, seem to be more consistent with the expected values of the parameter, in addition to improving coherence between the two versions of the model.
v1.6.11
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/78
States handling on Lag model
2021-01-07T17:47:27+01:00
Dorchies David
States handling on Lag model
## Analysis of the existing situation
In the lag model, upstream flows are added to the downstream flow with a delay. At the beginning of the simulation during this delay time, zero are currently added downstream because upstream flow b...
## Analysis of the existing situation
In the lag model, upstream flows are added to the downstream flow with a delay. At the beginning of the simulation during this delay time, zero are currently added downstream because upstream flow before the beginning of the simulation are not known. This period can be regarded as a warming period with initial zero flow upstream which lasts few days (Few time steps for a daily time step model).
## Requirements
The package **airGRiwrm** will need to run the model time step by time step without warming period (See in-wop/airGRiwrm#19). So we need to be able to handle states of the Lag model both as initial states and states at the end of the simulation.
- the `IniStates` object embedded in `RunOptions` should store a list of vector, each vector containing the flows during the delay time of the upstream flow.
- the `OutputsModel` object should contains this same list in the `StateEnd` item.
Lag model would not be the only hydraulic propagation model, so the implementation needs to be generic for other hydraulic propagation models.
## Proposition of realisation
### Storage
Adding a `SD` item in both `IniStates` object and `StateEnd` item of `OutputsModel`. Its contents will be model dependant. For the lag model it consists in a list ordered by the upstream connections and each item of the list will store the flow for the time steps during the delay time of each upstream flow.
### Implementation
- [x] Modification of `createIniStates` with a new parameter `SD` default `NULL` and copy this parameter in the `IniStates` object
- [x] Modification of `CreateRunOptions` for handling the new `SD` item
- [x] Modification of `RunModelLag` to use the hydraulic initial states provided by `RunOptions` instead of zeros
- [x] Modification of `RunModelLag` to add hydraulic states at the end of the simulation in `OutputsModel$StateEnd$SD`
v1.6.10
Dorchies David
Dorchies David
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/77
Warn users in SeriesAggreg when ConvertFun is not provided
2021-01-06T10:07:56+01:00
Delaigue Olivier
Warn users in SeriesAggreg when ConvertFun is not provided
It may be a good idea to return a message when `SeriesAggreg()` is applied on a unknown object (e.g. not `InputsModel ` or `OutputsModel` objects) and `ConvertFun` is also not provided.
It may be a good idea to return a message when `SeriesAggreg()` is applied on a unknown object (e.g. not `InputsModel ` or `OutputsModel` objects) and `ConvertFun` is also not provided.
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/76
Group release history of non submited versions
2021-01-08T04:57:39+01:00
Delaigue Olivier
Group release history of non submited versions
Except for the very first versions of the packages. Only the package versions submitted to CRAN is subject to a history. Therefore, in the NEWS file, the information for the version 1.6.3.73 and the latest version should be grouped toget...
Except for the very first versions of the packages. Only the package versions submitted to CRAN is subject to a history. Therefore, in the NEWS file, the information for the version 1.6.3.73 and the latest version should be grouped together (nota: the latest version on the CRAN is the 1.4.3.65.)
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/75
Improve X6 parameter description
2021-01-06T08:08:15+01:00
Delaigue Olivier
Improve X6 parameter description
@vazken.andreassian, friday 18 December 2020 16:06:59
> @olivier.delaigue and @charles.perrin,
>
> I don't like the name of the X6 parameter in the airGR help file:
>
> - GR6J X1 production store capacity [mm]
> - GR6J X2 intercat...
@vazken.andreassian, friday 18 December 2020 16:06:59
> @olivier.delaigue and @charles.perrin,
>
> I don't like the name of the X6 parameter in the airGR help file:
>
> - GR6J X1 production store capacity [mm]
> - GR6J X2 intercatchment exchange coefficient [mm/d]
> - GR6J X3 routing store capacity [mm]
> - GR6J X4 unit hydrograph time constant [d]
> - GR6J X5 intercatchment exchange threshold [-]
> - **GR6J X6 coefficient for emptying exponential store [mm]**
>
> I didn't find the name that was given to him in the publications...
>
> Wouldn't "parameter of the exponential store" or "exponential store depletion coefficient" be better?
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/67
Add '['.InputsModel and '['.OutputsModel functions
2021-01-11T08:53:05+01:00
Delaigue Olivier
Add '['.InputsModel and '['.OutputsModel functions
We need have to move the `'['.Inputs.default()` & `'['.InputsModel()` functions from the [airGRdatassim](https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim) package to airGR.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim/-/issu...
We need have to move the `'['.Inputs.default()` & `'['.InputsModel()` functions from the [airGRdatassim](https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim) package to airGR.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim/-/issues/14
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/66
Add hyperref links for doi in references
2021-01-07T17:47:19+01:00
Delaigue Olivier
Add hyperref links for doi in references
It could be a good idea to add hyperref links for doi in references of the manual and the README file.
It could be a good idea to add hyperref links for doi in references of the manual and the README file.
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/62
Embed Oudin's Fortran code
2021-08-04T14:02:11+02:00
Delaigue Olivier
Embed Oudin's Fortran code
The [PREMHYCE](https://gitlab.irstea.fr/HYCAR-Hydro/PREMHYCE) project need a faster version of the `PE_Oudin()` function.
The vectorization of the code is not satisfactory, it would be preferable to integrate the Fortran version of the ...
The [PREMHYCE](https://gitlab.irstea.fr/HYCAR-Hydro/PREMHYCE) project need a faster version of the `PE_Oudin()` function.
The vectorization of the code is not satisfactory, it would be preferable to integrate the Fortran version of the code. I think that is a good idea to keep the R version of the code to facilitate the comprehension by the users. In this case we can add an argument to switch from the R code to the Fortran code.
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/61
Add the use of caRamel in the optimization vignette
2021-01-29T11:23:15+01:00
Delaigue Olivier
Add the use of caRamel in the optimization vignette
We may add the use of the [**caRamel**](https://CRAN.R-project.org/package=caRamel) package in the optimization vignette (and the airGR vignette). A code is provided with [this article](https://www.hydrol-earth-syst-sci.net/24/3189/2020/...
We may add the use of the [**caRamel**](https://CRAN.R-project.org/package=caRamel) package in the optimization vignette (and the airGR vignette). A code is provided with [this article](https://www.hydrol-earth-syst-sci.net/24/3189/2020/hess-24-3189-2020.html). @guillaume.thirel provided an initial version of this piece of code in his review of the paper.
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/58
T gradient in DataAltiExtrapolation_Valery only valid in Northern hemisphere
2021-01-11T12:02:48+01:00
Thirel Guillaume
T gradient in DataAltiExtrapolation_Valery only valid in Northern hemisphere
I suspect that the DataAltiExtrapolation_Valery T gradient defined in GradT_Valery2010() is only valid for the Northern hemisphere.
I suspect that the DataAltiExtrapolation_Valery T gradient defined in GradT_Valery2010() is only valid for the Northern hemisphere.
v2.0
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/50
Adjust TransfoParam_GR5H (production store)
2021-04-23T12:11:01+02:00
Thirel Guillaume
Adjust TransfoParam_GR5H (production store)
The transformation given for GR5H (coming from Andrea Ficchi's files) is different from other models regarding the production store.
`ParamOut[, 1] <- exp(1.5 * ParamIn[, 1])` vs `ParamOut[, 1] <- exp(ParamIn[, 1])` and `ParamOut[, 1] <...
The transformation given for GR5H (coming from Andrea Ficchi's files) is different from other models regarding the production store.
`ParamOut[, 1] <- exp(1.5 * ParamIn[, 1])` vs `ParamOut[, 1] <- exp(ParamIn[, 1])` and `ParamOut[, 1] <- log(ParamIn[, 1])/1.5` vs `ParamOut[, 1] <- log(ParamIn[, 1])`.
The 1.5 factor seems unnecessary as it provokes irrealistically high X1 values. We should try to remove it and check the impact on GR5H on our 240 catchments hourly dataset.
Issue made following a remark from @paul.astagneau
v1.6.11
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/46
Add vignette about airGRmaps
2022-07-18T17:40:11+02:00
Delaigue Olivier
Add vignette about airGRmaps
It is probably interesting to write a vignette about the parameter maps of the GR4J, GR5J and GR6J models. These maps are available on the [airGRmaps](https://sunshine.irstea.fr/app/airGRmaps) shiny app. May be it could be mixed in the v...
It is probably interesting to write a vignette about the parameter maps of the GR4J, GR5J and GR6J models. These maps are available on the [airGRmaps](https://sunshine.irstea.fr/app/airGRmaps) shiny app. May be it could be mixed in the vignette whose title is *Generalist parameter sets for the GR4J model*.
v2.0
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/45
Deprecate verbose and warning arguments
2021-01-11T18:14:55+01:00
Delaigue Olivier
Deprecate verbose and warning arguments
@guillaume.thirel, are `warning` and `verbose` arguments really useful?
The use of the `suppresseMessages()` and `suppressWarnings()` functions allows you to do the same thing.
Furthermore, in some functions the argument is named `verbos...
@guillaume.thirel, are `warning` and `verbose` arguments really useful?
The use of the `suppresseMessages()` and `suppressWarnings()` functions allows you to do the same thing.
Furthermore, in some functions the argument is named `verbose`, but it is used to suppress warning messages (e.g. `SeriesAggreg()`)...
v2.0
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/44
Add an example using the BoolCrit argument of CreateInputsCrit
2021-01-11T12:02:23+01:00
Delaigue Olivier
Add an example using the BoolCrit argument of CreateInputsCrit
Add an example using the `BoolCrit` argument of the `CreateInputsCrit()` function could be a good idea.
The difference with the `IndPeriod_Run` argument of the `CreateRunOptions()` function is not very intuitive for users.
This is parti...
Add an example using the `BoolCrit` argument of the `CreateInputsCrit()` function could be a good idea.
The difference with the `IndPeriod_Run` argument of the `CreateRunOptions()` function is not very intuitive for users.
This is particularly interesting for calibration above or below a flow threshold, for certain months of the year only, etc.
We should put this example in a help page or a vignette.
v2.0
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/38
hydroPSO package available again on CRAN
2023-10-19T13:45:22+02:00
Delaigue Olivier
hydroPSO package available again on CRAN
The **hydroPSO** package came back on CRAN and can again be suggested in the **DESCRIPTION** file.
The **hydroPSO** package came back on CRAN and can again be suggested in the **DESCRIPTION** file.
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/25
Add a regime calculation function
2021-01-06T11:43:24+01:00
Thirel Guillaume
Add a regime calculation function
(transfer from ticket https://forge.irstea.fr/issues/5445)
It could be nice to propose a function to calculate regime (for P, T, PE, Q, SnowPack, SCA) from an `OutputsModel `object and Qobs (or SWE obs or SCA obs) and also to plot them....
(transfer from ticket https://forge.irstea.fr/issues/5445)
It could be nice to propose a function to calculate regime (for P, T, PE, Q, SnowPack, SCA) from an `OutputsModel `object and Qobs (or SWE obs or SCA obs) and also to plot them.
This function could have as arguments the aggregation time step and a sliding window length.
v1.6.10
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/162
Add the streamflow-streamflow (Q-Q) model within airGR
2022-08-04T18:31:53+02:00
Pierre BRIGODE
Add the streamflow-streamflow (Q-Q) model within airGR
Add the streamflow-streamflow (Q-Q) model used by [Andréassian et al. (2012)](https://doi.org/10.1016/j.jhydrol.2011.10.007) in the airGR package (and then, in the airGRteaching) ?
Add the streamflow-streamflow (Q-Q) model used by [Andréassian et al. (2012)](https://doi.org/10.1016/j.jhydrol.2011.10.007) in the airGR package (and then, in the airGRteaching) ?
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/150
Implemente Daniela Peredo's work
2022-07-19T08:50:53+02:00
Thirel Guillaume
Implemente Daniela Peredo's work
That could be useful to add Daniela's work in airGR (see https://www.tandfonline.com/doi/full/10.1080/02626667.2022.2030864).
Maybe @paul.astagneau you have already implented it by the way?
That could be useful to add Daniela's work in airGR (see https://www.tandfonline.com/doi/full/10.1080/02626667.2022.2030864).
Maybe @paul.astagneau you have already implented it by the way?
https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/139
MeanAnSolidPrecip is by default the same for all Layers. Why?
2022-02-21T11:16:05+01:00
Thirel Guillaume
MeanAnSolidPrecip is by default the same for all Layers. Why?
In CreateRunOptions, if no MeanAnSolidPrecip is provided, the average of annual solid precipitation is computed and affected to MeanAnSolidPrecip for all layers. Why not affecting the average of annual solid precipitation for each layer ...
In CreateRunOptions, if no MeanAnSolidPrecip is provided, the average of annual solid precipitation is computed and affected to MeanAnSolidPrecip for all layers. Why not affecting the average of annual solid precipitation for each layer to the specific layer? I can't remember, @olivier.delaigue ...