airGR issueshttps://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues2021-11-03T14:13:11+01:00https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/98Calculate computation times for each CRAN version2021-11-03T14:13:11+01:00Thirel GuillaumeCalculate computation times for each CRAN versionIn order to keep trace of the evolution of the computing times after modifications of the packages, I think we should automatically calculate the computation times in a similar way as done in Coron et al. (2017) (https://doi.org/10.1016/...In order to keep trace of the evolution of the computing times after modifications of the packages, I think we should automatically calculate the computation times in a similar way as done in Coron et al. (2017) (https://doi.org/10.1016/j.envsoft.2017.05.002), Table B.3.
I propose that:
- each former CRAN version is tested now
- each future new version of the package is tested (before submission for detecting problems(?) and after publication on the CRAN)
- all tests done in Tab. B.3 are performed (i.e. runs and calibrations over 10 years for each hydrological + snow model combinations, 100 tries)
- other functions like `Imax`, `PE_Oudin`, `DataAltiExtrapolation_Valery` are tested (configuration to determine)
- at least one Windows machine and one Linux machine are tested, Mac if possible.v1.8https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/119Fix 'baseflow' reverse dependency2021-11-03T14:11:39+01:00Delaigue OlivierFix 'baseflow' reverse dependency'airGR' v1.6.11 breaks the CRAN version of the 'baseflow' package. The error was not returned by the automated reverse dependency checking that is running using 'revdepcheck' during the pipeline, but it was detected by the one of the CRA...'airGR' v1.6.11 breaks the CRAN version of the 'baseflow' package. The error was not returned by the automated reverse dependency checking that is running using 'revdepcheck' during the pipeline, but it was detected by the one of the CRAN.
The following error appears only when 'airGR' is not attached before running the example. I don't see where the 'revdepcheck' package does this automatically (by using `library()` or something else that causes the same behavior).
```
Package check result: OK
Changes to worse in reverse depends:
Package: baseflow
Check: examples
New result: ERROR
Running examples in 'baseflow-Ex.R' failed
The error most likely occurred in:
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: BaseflowFilter
> ### Title: Constructor function of class 'BaseflowFilter'
> ### Aliases: BaseflowFilter
> ### Keywords: manip
>
> ### ** Examples
>
> library(baseflow)
>
> # Loading example data from airGR package
> data(L0123001, package = 'airGR')
>
> # Defining BasinData object
>
> Name <- BasinInfo$BasinName
> startDate <- BasinObs$DatesR[1]
> endDate <- BasinObs$DatesR[length(BasinObs$DatesR)]
> P <- BasinObs$P
> PET <- BasinObs$E
> Qobs <- BasinObs$Qmm
>
> BasinData_Example <- BasinData(Name, startDate, endDate, P, PET, Qobs, fill = "GR4J")
Error in FUN(X[[i]], ...) : object 'RunModel_GR1A' not found
Calls: BasinData ... CreateInputsModel -> .GetFeatModel -> lapply -> FUN
```v1.8https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/120Add test using calibration algorithm with all models2021-06-15T11:59:00+02:00Delaigue OlivierAdd test using calibration algorithm with all modelsGR4J is currently the only model tested using the calibration algorithm. It might be a good idea to test the other models with calibrations, even if they are tested with simulations.GR4J is currently the only model tested using the calibration algorithm. It might be a good idea to test the other models with calibrations, even if they are tested with simulations.v1.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/121Calculate test coverage for the package2021-11-03T14:13:07+01:00Delaigue OlivierCalculate test coverage for the packageMaybe it would be good to add a package coverage test to get an idea of missing or inchoate tests (even if it doesn't make sense to reach 100 %).
I did a test to get an idea of the results (not everything seems right: e.g. 'frun_PE.f90...Maybe it would be good to add a package coverage test to get an idea of missing or inchoate tests (even if it doesn't make sense to reach 100 %).
I did a test to get an idea of the results (not everything seems right: e.g. 'frun_PE.f90')
```
> covr::package_coverage(type = "all")
airGR Coverage: 68.78%
R/PEdaily_Oudin.R: 0.00%
R/RunModel_CemaNeigeGR4H.R: 0.00%
R/RunModel_CemaNeigeGR5H.R: 0.00%
R/TransfoParam_CemaNeige.R: 0.00%
R/TransfoParam_CemaNeigeHyst.R: 0.00%
R/TransfoParam_GR1A.R: 0.00%
R/TransfoParam_GR2M.R: 0.00%
R/TransfoParam_GR4H.R: 0.00%
R/TransfoParam_GR5H.R: 0.00%
R/TransfoParam_GR5J.R: 0.00%
R/TransfoParam_GR6J.R: 0.00%
src/frun_PE.f90: 0.00%
R/CreateCalibOptions.R: 41.04%
R/CreateInputsModel.R: 53.55%
R/PE_Oudin.R: 54.55%
R/CreateRunOptions.R: 65.72%
R/CreateIniStates.R: 68.16%
R/UtilsErrorCrit.R: 69.41%
R/TransfoParam_Lag.R: 70.59%
R/RunModel_GR6J.R: 71.26%
R/RunModel_GR1A.R: 71.67%
R/RunModel_GR4H.R: 72.29%
R/RunModel_GR5J.R: 72.29%
R/CreateInputsCrit.R: 72.43%
R/RunModel_GR2M.R: 73.08%
R/Imax.R: 74.07%
R/RunModel_GR5H.R: 74.19%
R/DataAltiExtrapolation_Valery.R: 76.09%
R/Utils.R: 77.14%
R/RunModel_CemaNeigeGR6J.R: 77.56%
R/RunModel_CemaNeigeGR4J.R: 78.29%
R/RunModel_CemaNeigeGR5J.R: 78.29%
R/RunModel_GR4J.R: 78.31%
R/ErrorCrit_KGE2.R: 79.31%
src/frun_GR5H.f90: 79.41%
R/RunModel_CemaNeige.R: 79.59%
R/plot.OutputsModel.R: 80.37%
R/SeriesAggreg.list.R: 83.19%
R/RunModel_Lag.R: 83.33%
R/SeriesAggreg.data.frame.R: 84.56%
R/UtilsSeriesAggreg.R: 87.50%
R/ErrorCrit_KGE.R: 87.76%
R/TransfoParam_GR4J.R: 88.00%
src/utils_D.f90: 88.57%
R/Calibration_Michel.R: 89.43%
R/Calibration.R: 90.00%
R/ErrorCrit_RMSE.R: 90.48%
R/ErrorCrit_NSE.R: 91.30%
R/ErrorCrit.R: 93.88%
src/frun_GR6J.f90: 98.35%
R/RunModel.R: 100.00%
R/SeriesAggreg.InputsModel.R: 100.00%
R/SeriesAggreg.OutputsModel.R: 100.00%
R/SeriesAggreg.R: 100.00%
R/TransfoParam.R: 100.00%
src/airGR.c: 100.00%
src/frun_CEMANEIGE.f90: 100.00%
src/frun_GR1A.f90: 100.00%
src/frun_GR2M.f90: 100.00%
src/frun_GR4H.f90: 100.00%
src/frun_GR4J.f90: 100.00%
src/frun_GR5J.f90: 100.00%
src/utils_H.f90: 100.00%
```v1.8https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/138Gitlab-CI: Run CI an docker image and checks organisation2022-02-11T13:34:40+01:00Dorchies DavidGitlab-CI: Run CI an docker image and checks organisation# Using docker
Currently the checks are performed on a server hosted by Inrae at CINES Montpellier.
I run directly the checks in the environment of the server and I have manually compiled 3 versions of R:
- oldrel: 3.6.3
- patched: 4....# Using docker
Currently the checks are performed on a server hosted by Inrae at CINES Montpellier.
I run directly the checks in the environment of the server and I have manually compiled 3 versions of R:
- oldrel: 3.6.3
- patched: 4.0.5
- devel: 2020-04-28 r78328
We can see that these version are outdated and maintaining these version updated manually is a bit time-consuming.
Using docker images allows to always work with up-to-date versions of R and moreover allows to use the dedicated Gitlab-runner server managed by Inrae.
On the rocker/tidyverse repository, we can use the following versions (See https://hub.docker.com/r/rocker/tidyverse/tags):
- latest (which correspond today to the 4.1.1 "patched" version).
- devel
There is no alias for "old-rel", but we can manage it manually by picking up an old version we want to assure compatibility (for example `rocker/tidyverse:3.5`).
# Check organisation
Checks "on-cran" and checks "not-cran" are partially redundant. Maybe we can only run checks on "cran" and the totality of the tests to save running time.v1.7.0https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/146False positive reverse dependency check2022-03-10T09:43:30+01:00Dorchies DavidFalse positive reverse dependency checkAfter changing in #81, airGRteaching did not work anymore and the revdepcheck procedure didn't raise any error.After changing in #81, airGRteaching did not work anymore and the revdepcheck procedure didn't raise any error.v1.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/148revdepcheck failed on airGRiwrm installation2023-10-19T17:38:25+02:00Dorchies Davidrevdepcheck failed on airGRiwrm installationSame issue as #146, the installation of the dependency times out.Same issue as #146, the installation of the dependency times out.v1.7.6Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/151Gitlab-CI: check as cran failed because of tex dependencies2023-10-19T18:08:58+02:00Dorchies DavidGitlab-CI: check as cran failed because of tex dependencieshere the error message we have for 1 week ago:
`tlmgr: Local TeX Live (2021) is older than remote repository (2022).`here the error message we have for 1 week ago:
`tlmgr: Local TeX Live (2021) is older than remote repository (2022).`v1.7.6Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/171Check error: Direct call of 'as.data.frame.POSIXct()' is deprecated. Use 'as...2023-10-24T11:05:59+02:00Dorchies DavidCheck error: Direct call of 'as.data.frame.POSIXct()' is deprecated. Use 'as.data.frame.vector()' or 'as.data.frame()' insteadThis error has raised on the check for devel version of R since 16th of December.
It needs to be fixed for the next release.This error has raised on the check for devel version of R since 16th of December.
It needs to be fixed for the next release.v1.7.6https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/184CI: crash on dev branch2023-10-23T17:14:51+02:00Dorchies DavidCI: crash on dev branchSee pipeline https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/pipelines/50934 as example...
Todo:
- update DESCRIPTION file
- update .gitlab-ci.ymlSee pipeline https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/pipelines/50934 as example...
Todo:
- update DESCRIPTION file
- update .gitlab-ci.ymlv1.7.6Dorchies DavidDorchies David