airGR issueshttps://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues2021-01-11T12:01:57+01:00https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/64Add precision in PE_Oudin doc2021-01-11T12:01:57+01:00Thirel GuillaumeAdd precision in PE_Oudin docThe Oudin paper used meteorological data at the station level to calculate PE. This is not specified but it is likely that point PE data were then basin averaged. (this is also what we do in our team when we use SAFRAN gridded data)
We ...The Oudin paper used meteorological data at the station level to calculate PE. This is not specified but it is likely that point PE data were then basin averaged. (this is also what we do in our team when we use SAFRAN gridded data)
We should therefore add an advice to do that in the Details of the `PE_Oudin` doc. I propose the following:
> To calculate basin-wide Oudin potential evapotranspiration, it is advised, when possible, to use either station temperature or gridded temperature data to calculate PE and then average these PE values at the basin scale.v1.6.10https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/67Add '['.InputsModel and '['.OutputsModel functions2021-01-11T08:53:05+01:00Delaigue OlivierAdd '['.InputsModel and '['.OutputsModel functionsWe need have to move the `'['.Inputs.default()` & `'['.InputsModel()` functions from the [airGRdatassim](https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim) package to airGR.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim/-/issu...We need have to move the `'['.Inputs.default()` & `'['.InputsModel()` functions from the [airGRdatassim](https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim) package to airGR.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgrdatassim/-/issues/14v1.6.10https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/68Non-compliance with Fortran 95 standard2020-11-24T10:01:25+01:00Pelletier AntoineNon-compliance with Fortran 95 standardIn `src/frun_GR6J.f90` file, lines 299 to 312 are not compliant with Fortran 95 standard, because of the `GOTO` instruction. Te `GOTO` feature was considered obsolescent in Fortran 90 and it was recommanded to replace it by a `CASE` or a...In `src/frun_GR6J.f90` file, lines 299 to 312 are not compliant with Fortran 95 standard, because of the `GOTO` instruction. Te `GOTO` feature was considered obsolescent in Fortran 90 and it was recommanded to replace it by a `CASE` or an `IF ELSE` construct.
Here attached is a proposed construct that is compliant with Fortran 95 standard.[frun_GR6J.f90](/uploads/1839aa239dae4b9478bd181afcbecaa6/frun_GR6J.f90)v1.6.10