Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • airGR airGR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Redmine
    • Redmine
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • HYCAR-Hydro
  • airGRairGR
  • Issues
  • #47

Closed
Open
Created Apr 10, 2020 by Thirel Guillaume@guillaume.thirelOwner

Loop improvement of the frun_CEMANEIGE subroutine

The calculation of Pliq and Psol is done in the time loop. I think we can extract it from that loop. I.e. modify

      !--------------------------------------------------------------
      ! Time loop
      !--------------------------------------------------------------
      DO k=1,LInputs

        ! SolidPrecip and LiquidPrecip
        Pliq=(1.-InputsFracSolidPrecip(k))*InputsPrecip(k)
        Psol=InputsFracSolidPrecip(k)*InputsPrecip(k)

to

      ! SolidPrecip and LiquidPrecip
      Pliq=(1.-InputsFracSolidPrecip)*InputsPrecip
      Psol=InputsFracSolidPrecip*InputsPrecip

      !--------------------------------------------------------------
      ! Time loop
      !--------------------------------------------------------------
      DO k=1,LInputs

and then replace all Pliq and Psol by Pliq(k) and Psol(k).

Does it run faster @olivier.delaigue? A proposition of code is attached. frun_CEMANEIGE.f90

Edited Apr 12, 2020 by Delaigue Olivier
Assignee
Assign to
Time tracking