airGRteaching issueshttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues2023-07-21T10:11:55+02:00https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/75Modify vignette texts and plot labels using SI units2023-07-21T10:11:55+02:00Delaigue OlivierModify vignette texts and plot labels using SI unitsTo be consistent with the HESS policy about the [airGRteaching article](https://doi.org/10.5194/hess-2022-421), we need to modify vignette texts and plot labels using SI units or the [journal guideline](https://www.hydrology-and-earth-sy...To be consistent with the HESS policy about the [airGRteaching article](https://doi.org/10.5194/hess-2022-421), we need to modify vignette texts and plot labels using SI units or the [journal guideline](https://www.hydrology-and-earth-system-sciences.net/submission.html#math).
- year --> yr
- day --> dv0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/74Modify the warm-up periods in the 'v00_teaching_hydrology' vignette2023-07-21T10:31:53+02:00Delaigue OlivierModify the warm-up periods in the 'v00_teaching_hydrology' vignetteIn the section 'On the need to perform a model warm-up' change the 4-year warm-up period to a 1-year period to be consistent with the modification asked by the reviewer in the [airGRteaching article](https://doi.org/10.5194/hess-2022-421).In the section 'On the need to perform a model warm-up' change the 4-year warm-up period to a 1-year period to be consistent with the modification asked by the reviewer in the [airGRteaching article](https://doi.org/10.5194/hess-2022-421).v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/72Fix wrong URL in vignette bib file2023-07-13T08:59:01+02:00Delaigue OlivierFix wrong URL in vignette bib fileThe following URL is not active http://cemadoc.irstea.fr/cemoa/PUB00044634. It should be replaced by https://hal.inrae.fr/hal-02601503The following URL is not active http://cemadoc.irstea.fr/cemoa/PUB00044634. It should be replaced by https://hal.inrae.fr/hal-02601503v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/70Update the scientific reference in the 'CITATION' file2023-09-15T09:34:37+02:00Delaigue OlivierUpdate the scientific reference in the 'CITATION' fileWhen the article in [HESS](https://doi.org/10.5194/hess-2022-421) will be accepted, replace the [current one](https://doi.org/10.29007/qsqj).When the article in [HESS](https://doi.org/10.5194/hess-2022-421) will be accepted, replace the [current one](https://doi.org/10.29007/qsqj).v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/69Add missing author in the 'CITATION' file2023-05-23T11:26:19+02:00Delaigue OlivierAdd missing author in the 'CITATION' fileG. Thirel as been added in the 'DESCRIPTION' file but he is still missing in the manual reference in the 'CITATATION' file.G. Thirel as been added in the 'DESCRIPTION' file but he is still missing in the manual reference in the 'CITATATION' file.v0.3.2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/68Replace the use of 'personList' in the CITATION file2023-04-28T08:40:14+02:00Delaigue OlivierReplace the use of 'personList' in the CITATION filePackage CITATION file contains call(s) to old-style `personList()` or `as.personList()`. Please use `c()` on person objects instead to pass CRAN checks.Package CITATION file contains call(s) to old-style `personList()` or `as.personList()`. Please use `c()` on person objects instead to pass CRAN checks.v0.3.2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/67Remove warning message about' htmlwidgets' package in the README2022-12-20T09:40:20+01:00Delaigue OlivierRemove warning message about' htmlwidgets' package in the READMEThe warning message about the version of the 'htmlwidgets' package can be removed.
It is no longer relevant.The warning message about the version of the 'htmlwidgets' package can be removed.
It is no longer relevant.v0.3.2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/66Move the project in the airGRgalaxy repository2023-07-11T15:45:51+02:00Delaigue OlivierMove the project in the airGRgalaxy repository- [ ] Move the project into the [airGRgalaxy group](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy)
- [ ] Update the **URL** and **BugReports** items in the DESCRIPTION file- [ ] Move the project into the [airGRgalaxy group](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy)
- [ ] Update the **URL** and **BugReports** items in the DESCRIPTION filehttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/61Clean the 'dyplot' S3 method2022-09-13T10:48:15+02:00Delaigue OlivierClean the 'dyplot' S3 methodCurrently the `dyplot` method is not well defined.
- [x] replace the misnamed `dyplot.default()` function by an internal one (`.dyplot()`)
- [x] remove the `dyplot.default` alias from the 'dyplot' help page
- [x] rename the `dyplot.def...Currently the `dyplot` method is not well defined.
- [x] replace the misnamed `dyplot.default()` function by an internal one (`.dyplot()`)
- [x] remove the `dyplot.default` alias from the 'dyplot' help page
- [x] rename the `dyplot.default.Rd` file into `dyplot.Rd`
- [x] rename the `dyplot.default.R` file into `dyplot.R`
- [x] add the `dyplot.PrepGR`, `dyplot.CalGR` and `dyplot.SimGR` aliases and usages in the 'dyplot' help page
- [x] bring the `dyplot()`, `.dyplot()`, `dyplot.PrepGR()`, `dyplot.CalGR()` and `dyplot.SimGR()` functions together in the same filev0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/60Correct wrong argument definition in 'plot' and 'dyplot' help pages2022-08-04T08:59:18+02:00Delaigue OlivierCorrect wrong argument definition in 'plot' and 'dyplot' help pagesIn the `plot()` and `dyplot()` functions, currently the definition of the `x` argument is the definition of the `x` from `airGRdatassim::RunModel_DA()`...In the `plot()` and `dyplot()` functions, currently the definition of the `x` argument is the definition of the `x` from `airGRdatassim::RunModel_DA()`...v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/58Update 'about' and 'author' tabs2022-08-04T13:44:08+02:00Delaigue OlivierUpdate 'about' and 'author' tabs`tab_about.rmd`:
- add SD mode
- update feature diagram
`tab_authors.rmd`:
- add D. Dorchies in the airGR list
@david.dorchies, do you agree to appear?
If you wish you can send me a picture.
See: https://sunshine.irstea.fr/app/airG...`tab_about.rmd`:
- add SD mode
- update feature diagram
`tab_authors.rmd`:
- add D. Dorchies in the airGR list
@david.dorchies, do you agree to appear?
If you wish you can send me a picture.
See: https://sunshine.irstea.fr/app/airGRteachingv0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/47Add vignettes with exercises2022-12-20T09:44:22+01:00Delaigue OlivierAdd vignettes with exercisesIn order to publish an article about the package, it was decided to add vignetttes with exercises.In order to publish an article about the package, it was decided to add vignetttes with exercises.v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/41Improve doc of PrepGR concerning GR5H2021-07-26T17:10:50+02:00Thirel GuillaumeImprove doc of PrepGR concerning GR5HWe have to add in the Details section that in airGRteaching, GR5H can be used only without the interception from Ficchi, i.e. without specifying `Imax`.We have to add in the Details section that in airGRteaching, GR5H can be used only without the interception from Ficchi, i.e. without specifying `Imax`.v0.2.12https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/34Use user-defined macros in the manual2021-01-12T15:15:39+01:00Delaigue OlivierUse user-defined macros in the manualIt is possible to use user-defines macros in order not to write a new time the package title, the package description, etc. For references, it is also possible to replace the `href` mark by the `doi` mark.
* `\packageTitle`
* `\packageD...It is possible to use user-defines macros in order not to write a new time the package title, the package description, etc. For references, it is also possible to replace the `href` mark by the `doi` mark.
* `\packageTitle`
* `\packageDescription`
* `\packageAuthor`
* `\packageMaintainer`
* `\packageDESCRIPTION`
* `\packageIndices`
* `\doi`
See *[Writing R Extensions](https://cloud.r-project.org/doc/manuals/R-exts.html#User_002ddefined-macros)*[ (User-defined macros)](https://cloud.r-project.org/doc/manuals/R-exts.html#User_002ddefined-macros)
This avoids, for example, possible differences between the title of the description file and the title of the package's help page.v0.2.10https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/33Reformat the NEWS file2021-01-15T15:31:20+01:00Delaigue OlivierReformat the NEWS file* remove blank lines between items in the lists
* replace the `<code>` & `</code>` markups by the more readable `'` sign* remove blank lines between items in the lists
* replace the `<code>` & `</code>` markups by the more readable `'` signv0.2.10https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/31Change X6 parameter description2020-12-21T08:22:39+01:00Delaigue OlivierChange X6 parameter descriptionNew description: * **GR6J X6 exponential store depletion coefficient \[mm\]**
To be changed in the GUI.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/75New description: * **GR6J X6 exponential store depletion coefficient \[mm\]**
To be changed in the GUI.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/75v0.2.10https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/28Explicit links to other packages in documentation2020-10-22T09:43:41+02:00Delaigue OlivierExplicit links to other packages in documentationAdded exlicit links to external functions:
- `\code{\link{function}}`: function in this package
- `\code{\link[MASS]{abbey}}`: function in another package
- `\link[=dest]{name}`: link to dest, but show name
- `\code{\link[MASS:abbey]{na...Added exlicit links to external functions:
- `\code{\link{function}}`: function in this package
- `\code{\link[MASS]{abbey}}`: function in another package
- `\link[=dest]{name}`: link to dest, but show name
- `\code{\link[MASS:abbey]{name}}`: link to function in another package, but show name
- `\linkS4class{abc}`: link to an S4 classhttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/27Fix manual compilation error2022-09-08T10:17:52+02:00Delaigue OlivierFix manual compilation errorThere are errors when compiling the LaTex code in the manual. The package does not pass the CRAN checks.There are errors when compiling the LaTex code in the manual. The package does not pass the CRAN checks.https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/26Bug reports link2020-06-17T18:52:27+02:00Delaigue OlivierBug reports linkA `BugReports` item have to be added in the *DESCRIPTION* file.
```
BugReports: https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/issues
```A `BugReports` item have to be added in the *DESCRIPTION* file.
```
BugReports: https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/issues
```https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/21Make a video to illustrate the use of the GUI2021-10-19T11:10:49+02:00Thirel GuillaumeMake a video to illustrate the use of the GUIWe could quite easily make a video showing how to use the GUI and how to navigate on it.
Several softwares that allow for capturing the screen exist.
In addition, I installed and used the ShotCut software on my laptop. This permits to ...We could quite easily make a video showing how to use the GUI and how to navigate on it.
Several softwares that allow for capturing the screen exist.
In addition, I installed and used the ShotCut software on my laptop. This permits to make video editing. It is quite easy to use and very powerful.
For doing that, we would need to write a 'pitch' of what we want to show, what we want to say. We would also need a good microphone. And maybe someone with a better accent than us for the comments. :)