airGRteaching issueshttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues2021-01-20T10:24:40+01:00https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/36Take into account the '[.OutputsModel' method defined in airGR2021-01-20T10:24:40+01:00Delaigue OlivierTake into account the '[.OutputsModel' method defined in airGRThe '[.OutputsModel' method breaks the use of the `ShinyGR()` function... (line 379 of the server file).
The fixed code need to run with or without this method.The '[.OutputsModel' method breaks the use of the `ShinyGR()` function... (line 379 of the server file).
The fixed code need to run with or without this method.https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/18Trouble when the Period slider is set manually2020-04-14T08:18:51+02:00Delaigue OlivierTrouble when the Period slider is set manuallyWhen we set the *Period* slider manually on the *State variables* and the *Model diagram* panels, the first date of the slider moves from one time step.
This does not appear on the *Flow time series* and the *Model performance* panels. ...When we set the *Period* slider manually on the *State variables* and the *Model diagram* panels, the first date of the slider moves from one time step.
This does not appear on the *Flow time series* and the *Model performance* panels. This also does not appear when the *Period* is set by zooming on the dynamic graphs.
This is an old bug.https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/17Remove useless eventReactive to update Event slider when a new dataset is sel...2021-01-20T10:27:25+01:00Delaigue OlivierRemove useless eventReactive to update Event slider when a new dataset is selectedThe following commands seem to be useless. This needs to be checked.
```r
eventReactive({input$Dataset}, {
updateSliderInput(session, inputId = "Event", label = "Select the target date:",
min = as.POSIXct(.Sh...The following commands seem to be useless. This needs to be checked.
```r
eventReactive({input$Dataset}, {
updateSliderInput(session, inputId = "Event", label = "Select the target date:",
min = as.POSIXct(.ShinyGR.args$SimPer[[input$Dataset]][1L], tz = "UTC"),## + .TypeModelGR(input$HydroModel)$TimeLag,
max = as.POSIXct(.ShinyGR.args$SimPer[[input$Dataset]][2L], tz = "UTC"),
value = as.POSIXct(.ShinyGR.args$SimPer[[input$Dataset]][1L], tz = "UTC"), + .TypeModelGR(input$HydroModel)$TimeLag,
timeFormat = timeFormat, timezone = "+0000")
})
```
In addition, the `value` argument seems to be wrong. It seems to be an extra comma that puts time into another argument when it seems to need to be added up.
```r
## wrong?
value = as.POSIXct(.ShinyGR.args$SimPer[[input$Dataset]][1L], tz = "UTC"), + .TypeModelGR(input$HydroModel)$TimeLag
## right?
value = as.POSIXct(.ShinyGR.args$SimPer[[input$Dataset]][1L], tz = "UTC") + .TypeModelGR(input$HydroModel)$TimeLag
```