airGRteaching issueshttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues2023-10-20T13:09:55+02:00https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/76Add a message to explain how to disconnect the GUI2023-10-20T13:09:55+02:00Delaigue OlivierAdd a message to explain how to disconnect the GUIDisplay a message to explain user launching the GUI from the `ShinyGR` function how to disconnect it from R:
> Press the 'escape' key to disconnect the graphical user interfaceDisplay a message to explain user launching the GUI from the `ShinyGR` function how to disconnect it from R:
> Press the 'escape' key to disconnect the graphical user interfacev0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/74Modify the warm-up periods in the 'v00_teaching_hydrology' vignette2023-07-21T10:31:53+02:00Delaigue OlivierModify the warm-up periods in the 'v00_teaching_hydrology' vignetteIn the section 'On the need to perform a model warm-up' change the 4-year warm-up period to a 1-year period to be consistent with the modification asked by the reviewer in the [airGRteaching article](https://doi.org/10.5194/hess-2022-421).In the section 'On the need to perform a model warm-up' change the 4-year warm-up period to a 1-year period to be consistent with the modification asked by the reviewer in the [airGRteaching article](https://doi.org/10.5194/hess-2022-421).v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/75Modify vignette texts and plot labels using SI units2023-07-21T10:11:55+02:00Delaigue OlivierModify vignette texts and plot labels using SI unitsTo be consistent with the HESS policy about the [airGRteaching article](https://doi.org/10.5194/hess-2022-421), we need to modify vignette texts and plot labels using SI units or the [journal guideline](https://www.hydrology-and-earth-sy...To be consistent with the HESS policy about the [airGRteaching article](https://doi.org/10.5194/hess-2022-421), we need to modify vignette texts and plot labels using SI units or the [journal guideline](https://www.hydrology-and-earth-system-sciences.net/submission.html#math).
- year --> yr
- day --> dv0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/65Install the 'airGRdatasets' package from the CRAN2022-12-13T09:12:42+01:00Delaigue OlivierInstall the 'airGRdatasets' package from the CRANIn the Yaml file we can replace the [GitLab version](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy/airgrdatasets) of the 'airGRdatasets' by the [CRAN one](https://CRAN.R-project.org/package=airGRdatasets).In the Yaml file we can replace the [GitLab version](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy/airgrdatasets) of the 'airGRdatasets' by the [CRAN one](https://CRAN.R-project.org/package=airGRdatasets).v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/6Allow other graphical outputs in the functions 'plot.CalGR' and 'plot.SimGR'2022-10-28T10:11:43+02:00Delaigue OlivierAllow other graphical outputs in the functions 'plot.CalGR' and 'plot.SimGR'It is liked to the new graphical outputs of the `airGR::plot` function (`which` argument).
See the [airGR package](https://gitlab.irstea.fr/HYCAR-Hydro/airgr).It is liked to the new graphical outputs of the `airGR::plot` function (`which` argument).
See the [airGR package](https://gitlab.irstea.fr/HYCAR-Hydro/airgr).v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/2Add calendar on the GUI2022-10-06T11:41:44+02:00Thirel GuillaumeAdd calendar on the GUIA suggestion that is made very often about the ShinyGR interface. As it is difficult to pick up a specific date with the cursors in the interface, it could be useful to add a calendar on whoch to choose the precise date.A suggestion that is made very often about the ShinyGR interface. As it is difficult to pick up a specific date with the cursors in the interface, it could be useful to add a calendar on whoch to choose the precise date.https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/62Add functions to help user to get some values from 'CalGR' and 'SimGR' objects2022-08-04T10:24:42+02:00Delaigue OlivierAdd functions to help user to get some values from 'CalGR' and 'SimGR' objectsThe outputs of the `CalGR()` and `SimGR()` functions are quite complex because they are lists of outputs of airGR functions.
It is therefore difficult to extract the values of parameters or criteria for people who are new to programmin...The outputs of the `CalGR()` and `SimGR()` functions are quite complex because they are lists of outputs of airGR functions.
It is therefore difficult to extract the values of parameters or criteria for people who are new to programming.
It could be maybe usefull to provides functions to get these elements.v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/52Change the default configuration of the "WupPer" argument (SimGR and CalGR fu...2022-07-28T11:25:50+02:00Pierre BRIGODEChange the default configuration of the "WupPer" argument (SimGR and CalGR functions)No matter if the "WupPer" argument is (i) not defined, (ii) equal to NULL or (iii) equal to 0L, a default configuration is applied to the model warm up period, namely the year preceding the run period is used. Thus, it is impossible to p...No matter if the "WupPer" argument is (i) not defined, (ii) equal to NULL or (iii) equal to 0L, a default configuration is applied to the model warm up period, namely the year preceding the run period is used. Thus, it is impossible to perform a simulation without model warm-up.
Is it possible to change this default configuration as for airGR?v0.3.1Delaigue OlivierDelaigue Olivierhttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/43Allow to simulate a subperiod without discharge in SimGR2021-08-18T10:24:26+02:00Delaigue OlivierAllow to simulate a subperiod without discharge in SimGR## Current behaviour
It is possible to run `SimGR()` using a `PrepGR()` output whthout anny Qobs, but it is not possible when it is only a sub-period.
### On the whole periode without `Obs`:
```r
## data.frame of observed data
data(L0...## Current behaviour
It is possible to run `SimGR()` using a `PrepGR()` output whthout anny Qobs, but it is not possible when it is only a sub-period.
### On the whole periode without `Obs`:
```r
## data.frame of observed data
data(L0123001, package = "airGR")
BasinObs2 <- BasinObs[, c("DatesR", "P", "E", "Qmm", "T")]
BasinObs2$Qmm <- NA
### Preparation of observed data for modelling
PREP <- PrepGR(ObsDF = BasinObs2, HydroModel = "GR4J", CemaNeige = FALSE)
## Simulation step using model parameters set by the user
SIM <- SimGR(PrepGR = PREP, Param = c(270.426, 0.984, 108.853, 2.149), EffCrit = "KGE2",
WupPer = NULL, SimPer = c("1994-01-01", "1998-12-31"))
```
```
Warning messages:
1: In SimGR(PrepGR = PREP, Param = c(270.426, 0.984, 108.853, 2.149), :
"PrepGR" does not contain any Qobs values. The efficiency criterion is not computed
2: In CreateRunOptions(FUN_MOD = get(PrepGR$TypeModel), InputsModel = PrepGR$InputsModel, :
model warm up period not defined: default configuration used
the year preceding the run period is used
```
### On a subperiod without `Obs`:
```r
## data.frame of observed data
data(L0123001, package = "airGR")
BasinObs2 <- BasinObs[, c("DatesR", "P", "E", "Qmm", "T")]
BasinObs2$Qmm[3654:length(BasinObs2$Qmm)] <- NA
## Preparation of observed data for modelling
PREP <- PrepGR(ObsDF = BasinObs2, HydroModel = "GR4J", CemaNeige = FALSE)
## Simulation step using model parameters set by the user
SIM <- SimGR(PrepGR = PREP, Param = c(270.426, 0.984, 108.853, 2.149), EffCrit = "KGE2",
WupPer = NULL, SimPer = c("1994-01-01", "1998-12-31"))
```
```
Erreur : 'Obs' contains only missing values
De plus : Warning message:
In CreateRunOptions(FUN_MOD = get(PrepGR$TypeModel), InputsModel = PrepGR$InputsModel, :
model warm up period not defined: default configuration used
the year preceding the run period is used
```
## Expected behaviour
Allow to run `SimGR()` on a subperiod whitout discharge and return a warning message.
### Current code
Lines 19 to 22
```r
isQobs <- !all(is.na(PrepGR$Qobs))
if (!isQobs) {
warning("\"PrepGR\" does not contain any Qobs values. The efficiency criterion is not computed")
}
```
Lines 82 to 98
```r
if (isQobs) {
MOD_crt <- CreateInputsCrit(FUN_CRIT = FUN_CRIT, InputsModel = PrepGR$InputsModel,
RunOptions = MOD_opt, Obs = PrepGR$Qobs[SimInd],
transfo = transfo)
}
else {
MOD_crt <- NULL
}
SIM <- RunModel(InputsModel = PrepGR$InputsModel, RunOptions = MOD_opt,
Param = Param, FUN_MOD = get(PrepGR$TypeModel))
if (isQobs) {
CRT <- ErrorCrit(InputsCrit = MOD_crt, OutputsModel = SIM,
verbose = verbose)
}
else {
CRT <- NULL
}
```
### Proposed solution
Remove ines 19 to 22.
Add the following code just before the line 82:
```r
isQobs <- !all(is.na(PrepGR$Qobs[SimInd]))
if (!isQobs) {
warning("\"PrepGR\" does not contain any Qobs values on \"SimPer\". The efficiency criterion is not computed")
}
```v0.2.12https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/32Display a space separator between thousands places in numbers2021-07-26T17:09:48+02:00Delaigue OlivierDisplay a space separator between thousands places in numbersThe sign currently used as a separator for the sliders of the GUI is ambiguous, especially for French students.
I could be a better idea to use a **space** instead of a **coma**.
[Three ways to group the number ten thousand with digit g...The sign currently used as a separator for the sliders of the GUI is ambiguous, especially for French students.
I could be a better idea to use a **space** instead of a **coma**.
[Three ways to group the number ten thousand with digit group separators](https://en.wikipedia.org/wiki/Decimal_separator):
1) Space, the internationally recommended thousands separator.
2) Period (spoken as point), the thousands separator in many non-English speaking countries.
3) Comma, the thousands separator used in most English-speaking countries.v0.2.10https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/14Add GR2M in the GUI2021-07-22T16:11:07+02:00Delaigue OlivierAdd GR2M in the GUIThe GR2M model is widely used, especially in teaching. It should be added in the GUI.The GR2M model is widely used, especially in teaching. It should be added in the GUI.v0.2.10https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/39Set as.data.frame method for 'PrepGR', 'CalGR' and 'SimGR' classes2021-06-07T17:34:31+02:00Delaigue OlivierSet as.data.frame method for 'PrepGR', 'CalGR' and 'SimGR' classesReplace as `as.data.frame.airGRt` function by `as.data.frame` S3 method for class 'PrepGR', 'CalGR' and 'SimGR'Replace as `as.data.frame.airGRt` function by `as.data.frame` S3 method for class 'PrepGR', 'CalGR' and 'SimGR'v0.2.11https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/31Change X6 parameter description2020-12-21T08:22:39+01:00Delaigue OlivierChange X6 parameter descriptionNew description: * **GR6J X6 exponential store depletion coefficient \[mm\]**
To be changed in the GUI.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/75New description: * **GR6J X6 exponential store depletion coefficient \[mm\]**
To be changed in the GUI.
See https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/75v0.2.10https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/13Update interface screenshots2020-06-23T08:31:08+02:00Delaigue OlivierUpdate interface screenshotsSee https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching-website/-/issues/2See https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching-website/-/issues/2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/1Calibration on subperiod with scores on complete period2020-06-23T08:05:26+02:00Thirel GuillaumeCalibration on subperiod with scores on complete periodSuggestion from Alain Dezetter
> it could be nice to have access to the scores (in the table on the right) on the complete period in the ShinyGR interface when we perform a calibration on a subperiod.Suggestion from Alain Dezetter
> it could be nice to have access to the scores (in the table on the right) on the complete period in the ShinyGR interface when we perform a calibration on a subperiod.https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/8Add the possibility not to provide discharge to PrepGR2020-02-13T11:44:15+01:00Thirel GuillaumeAdd the possibility not to provide discharge to PrepGR