airGRteaching issueshttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues2020-02-13T11:44:15+01:00https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/8Add the possibility not to provide discharge to PrepGR2020-02-13T11:44:15+01:00Thirel GuillaumeAdd the possibility not to provide discharge to PrepGRhttps://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/76Add a message to explain how to disconnect the GUI2023-10-20T13:09:55+02:00Delaigue OlivierAdd a message to explain how to disconnect the GUIDisplay a message to explain user launching the GUI from the `ShinyGR` function how to disconnect it from R:
> Press the 'escape' key to disconnect the graphical user interfaceDisplay a message to explain user launching the GUI from the `ShinyGR` function how to disconnect it from R:
> Press the 'escape' key to disconnect the graphical user interfacev0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/75Modify vignette texts and plot labels using SI units2023-07-21T10:11:55+02:00Delaigue OlivierModify vignette texts and plot labels using SI unitsTo be consistent with the HESS policy about the [airGRteaching article](https://doi.org/10.5194/hess-2022-421), we need to modify vignette texts and plot labels using SI units or the [journal guideline](https://www.hydrology-and-earth-sy...To be consistent with the HESS policy about the [airGRteaching article](https://doi.org/10.5194/hess-2022-421), we need to modify vignette texts and plot labels using SI units or the [journal guideline](https://www.hydrology-and-earth-system-sciences.net/submission.html#math).
- year --> yr
- day --> dv0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/74Modify the warm-up periods in the 'v00_teaching_hydrology' vignette2023-07-21T10:31:53+02:00Delaigue OlivierModify the warm-up periods in the 'v00_teaching_hydrology' vignetteIn the section 'On the need to perform a model warm-up' change the 4-year warm-up period to a 1-year period to be consistent with the modification asked by the reviewer in the [airGRteaching article](https://doi.org/10.5194/hess-2022-421).In the section 'On the need to perform a model warm-up' change the 4-year warm-up period to a 1-year period to be consistent with the modification asked by the reviewer in the [airGRteaching article](https://doi.org/10.5194/hess-2022-421).v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/73Do not export anymore "private" functions2023-08-25T17:48:34+02:00Delaigue OlivierDo not export anymore "private" functionsThe CRAN no longer accepts the export of functions whose name begins with a dot without documentation.
So the following functions have to be removed from the NAMESPACE file:
```
.CheckUrl
.DiagramGR
.DyShadingMulti
.StartStop
.TypeMo...The CRAN no longer accepts the export of functions whose name begins with a dot without documentation.
So the following functions have to be removed from the NAMESPACE file:
```
.CheckUrl
.DiagramGR
.DyShadingMulti
.StartStop
.TypeModelGR
```v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/72Fix wrong URL in vignette bib file2023-07-13T08:59:01+02:00Delaigue OlivierFix wrong URL in vignette bib fileThe following URL is not active http://cemadoc.irstea.fr/cemoa/PUB00044634. It should be replaced by https://hal.inrae.fr/hal-02601503The following URL is not active http://cemadoc.irstea.fr/cemoa/PUB00044634. It should be replaced by https://hal.inrae.fr/hal-02601503v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/71Fix the use of the 'log_scale ' argument in 'plot.CalGR' and 'plot.SimGR'2023-07-11T11:11:41+02:00Delaigue OlivierFix the use of the 'log_scale ' argument in 'plot.CalGR' and 'plot.SimGR'As `airGR::plot.OutputsModel()` is called without the use o the `...` argument in `plot.CalGR` and `plot.SimGR`, these functions do not return anymore the logarithm streamflow.As `airGR::plot.OutputsModel()` is called without the use o the `...` argument in `plot.CalGR` and `plot.SimGR`, these functions do not return anymore the logarithm streamflow.v0.3.2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/70Update the scientific reference in the 'CITATION' file2023-09-15T09:34:37+02:00Delaigue OlivierUpdate the scientific reference in the 'CITATION' fileWhen the article in [HESS](https://doi.org/10.5194/hess-2022-421) will be accepted, replace the [current one](https://doi.org/10.29007/qsqj).When the article in [HESS](https://doi.org/10.5194/hess-2022-421) will be accepted, replace the [current one](https://doi.org/10.29007/qsqj).v0.3.3https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/69Add missing author in the 'CITATION' file2023-05-23T11:26:19+02:00Delaigue OlivierAdd missing author in the 'CITATION' fileG. Thirel as been added in the 'DESCRIPTION' file but he is still missing in the manual reference in the 'CITATATION' file.G. Thirel as been added in the 'DESCRIPTION' file but he is still missing in the manual reference in the 'CITATATION' file.v0.3.2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/68Replace the use of 'personList' in the CITATION file2023-04-28T08:40:14+02:00Delaigue OlivierReplace the use of 'personList' in the CITATION filePackage CITATION file contains call(s) to old-style `personList()` or `as.personList()`. Please use `c()` on person objects instead to pass CRAN checks.Package CITATION file contains call(s) to old-style `personList()` or `as.personList()`. Please use `c()` on person objects instead to pass CRAN checks.v0.3.2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/67Remove warning message about' htmlwidgets' package in the README2022-12-20T09:40:20+01:00Delaigue OlivierRemove warning message about' htmlwidgets' package in the READMEThe warning message about the version of the 'htmlwidgets' package can be removed.
It is no longer relevant.The warning message about the version of the 'htmlwidgets' package can be removed.
It is no longer relevant.v0.3.2https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/65Install the 'airGRdatasets' package from the CRAN2022-12-13T09:12:42+01:00Delaigue OlivierInstall the 'airGRdatasets' package from the CRANIn the Yaml file we can replace the [GitLab version](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy/airgrdatasets) of the 'airGRdatasets' by the [CRAN one](https://CRAN.R-project.org/package=airGRdatasets).In the Yaml file we can replace the [GitLab version](https://gitlab.irstea.fr/HYCAR-Hydro/airgrgalaxy/airgrdatasets) of the 'airGRdatasets' by the [CRAN one](https://CRAN.R-project.org/package=airGRdatasets).v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/64Fix 'SimGR' tests when running on a non UTC timezone2022-11-04T10:25:10+01:00Delaigue OlivierFix 'SimGR' tests when running on a non UTC timezoneFrom: Joshua Ulrich 3 November 2022 20:45
CC: Kurt Hornik
> One package test fails when I run 'R CMD check' with a non-UTC timezone. I found this issue while running reverse-dependency checks for xts. I wanted to make sure it wasn't ...From: Joshua Ulrich 3 November 2022 20:45
CC: Kurt Hornik
> One package test fails when I run 'R CMD check' with a non-UTC timezone. I found this issue while running reverse-dependency checks for xts. I wanted to make sure it wasn't an xts bug.
>
> There's a reproducible example below. Kurt found the issue is with the lines that compare dates with a character string, because the result is locale-dependent.
>
> Let me know if you have questions.
```r
# the expected result (a warning)
Sys.setenv(TZ="UTC")
require(airGRteaching)
data(L0123001, package = "airGR")
BasinObsSubNA <- BasinObs[, c("DatesR", "P", "E", "Qmm", "T")]
BasinObsSubNA[BasinObsSubNA$DatesR >= "1994-01-01", ]$Qmm <- NA
BasinObsTotNA <- BasinObsSubNA[BasinObsSubNA$DatesR >= "1994-01-01", ]
PrepSubNA <- PrepGR(ObsDF = BasinObsSubNA, HydroModel = "GR4J", CemaNeige = FALSE)
PrepTotNA <- PrepGR(ObsDF = BasinObsTotNA, HydroModel = "GR4J", CemaNeige = FALSE)
object <- SimGR(PrepGR = PrepTotNA, Param = c(270.426, 0.984, 108.853, 2.149),
EffCrit = "KGE2", WupPer = c("1994-01-01", "1994-12-31"),
SimPer = c("1995-01-01", "1998-12-31")) ## Warning message:
## In SimGR(PrepGR = PrepTotNA, Param = c(270.426, 0.984, 108.853, :
## "PrepGR" does not contain any Qobs values. The efficiency criterion is not computed
```
```r
# error if the timezone isn't UTC
Sys.setenv(TZ="America/Chicago")
require(airGRteaching)
data(L0123001, package = "airGR")
BasinObsSubNA <- BasinObs[, c("DatesR", "P", "E", "Qmm", "T")]
BasinObsSubNA[BasinObsSubNA$DatesR >= "1994-01-01", ]$Qmm <- NA
BasinObsTotNA <- BasinObsSubNA[BasinObsSubNA$DatesR >= "1994-01-01", ]
PrepSubNA <- PrepGR(ObsDF = BasinObsSubNA, HydroModel = "GR4J", CemaNeige = FALSE)
PrepTotNA <- PrepGR(ObsDF = BasinObsTotNA, HydroModel = "GR4J", CemaNeige = FALSE)
object <- SimGR(PrepGR = PrepTotNA, Param = c(270.426, 0.984, 108.853, 2.149),
EffCrit = "KGE2", WupPer = c("1994-01-01", "1994-12-31"),
SimPer = c("1995-01-01", "1998-12-31")) ## Error in SimGR(PrepGR = PrepTotNA, Param = c(270.426, 0.984, 108.853, :
## Non convenient date for the warm-up period "WupPer"
```v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/63Correct the default graph displaying by 'plot.CalGR'2023-01-06T08:54:18+01:00Delaigue OlivierCorrect the default graph displaying by 'plot.CalGR'Currently, `plot.CalGR()` returns the "synth" graph when which = "perf" (default value).Currently, `plot.CalGR()` returns the "synth" graph when which = "perf" (default value).v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/62Add functions to help user to get some values from 'CalGR' and 'SimGR' objects2022-08-04T10:24:42+02:00Delaigue OlivierAdd functions to help user to get some values from 'CalGR' and 'SimGR' objectsThe outputs of the `CalGR()` and `SimGR()` functions are quite complex because they are lists of outputs of airGR functions.
It is therefore difficult to extract the values of parameters or criteria for people who are new to programmin...The outputs of the `CalGR()` and `SimGR()` functions are quite complex because they are lists of outputs of airGR functions.
It is therefore difficult to extract the values of parameters or criteria for people who are new to programming.
It could be maybe usefull to provides functions to get these elements.v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/61Clean the 'dyplot' S3 method2022-09-13T10:48:15+02:00Delaigue OlivierClean the 'dyplot' S3 methodCurrently the `dyplot` method is not well defined.
- [x] replace the misnamed `dyplot.default()` function by an internal one (`.dyplot()`)
- [x] remove the `dyplot.default` alias from the 'dyplot' help page
- [x] rename the `dyplot.def...Currently the `dyplot` method is not well defined.
- [x] replace the misnamed `dyplot.default()` function by an internal one (`.dyplot()`)
- [x] remove the `dyplot.default` alias from the 'dyplot' help page
- [x] rename the `dyplot.default.Rd` file into `dyplot.Rd`
- [x] rename the `dyplot.default.R` file into `dyplot.R`
- [x] add the `dyplot.PrepGR`, `dyplot.CalGR` and `dyplot.SimGR` aliases and usages in the 'dyplot' help page
- [x] bring the `dyplot()`, `.dyplot()`, `dyplot.PrepGR()`, `dyplot.CalGR()` and `dyplot.SimGR()` functions together in the same filev0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/60Correct wrong argument definition in 'plot' and 'dyplot' help pages2022-08-04T08:59:18+02:00Delaigue OlivierCorrect wrong argument definition in 'plot' and 'dyplot' help pagesIn the `plot()` and `dyplot()` functions, currently the definition of the `x` argument is the definition of the `x` from `airGRdatassim::RunModel_DA()`...In the `plot()` and `dyplot()` functions, currently the definition of the `x` argument is the definition of the `x` from `airGRdatassim::RunModel_DA()`...v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/59Update icon names2022-07-27T09:44:45+02:00Delaigue OlivierUpdate icon namesThe `ShinyGR()` function returns the following warning messages.
The ui.R and the server.R files need to be updated.
```
This Font Awesome icon ('sync') does not exist:
* if providing a custom `html_dependency` these `name` checks ...The `ShinyGR()` function returns the following warning messages.
The ui.R and the server.R files need to be updated.
```
This Font Awesome icon ('sync') does not exist:
* if providing a custom `html_dependency` these `name` checks can
be deactivated with `verify_fa = FALSE`
This Font Awesome icon ('th') does not exist:
* if providing a custom `html_dependency` these `name` checks can
be deactivated with `verify_fa = FALSE`
This Font Awesome icon ('question-circle') does not exist:
* if providing a custom `html_dependency` these `name` checks can
be deactivated with `verify_fa = FALSE`
This Font Awesome icon ('sync') does not exist:
* if providing a custom `html_dependency` these `name` checks can
be deactivated with `verify_fa = FALSE`
```v0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/58Update 'about' and 'author' tabs2022-08-04T13:44:08+02:00Delaigue OlivierUpdate 'about' and 'author' tabs`tab_about.rmd`:
- add SD mode
- update feature diagram
`tab_authors.rmd`:
- add D. Dorchies in the airGR list
@david.dorchies, do you agree to appear?
If you wish you can send me a picture.
See: https://sunshine.irstea.fr/app/airG...`tab_about.rmd`:
- add SD mode
- update feature diagram
`tab_authors.rmd`:
- add D. Dorchies in the airGR list
@david.dorchies, do you agree to appear?
If you wish you can send me a picture.
See: https://sunshine.irstea.fr/app/airGRteachingv0.3.1https://gitlab.irstea.fr/HYCAR-Hydro/airgrteaching/-/issues/57Update the sunshine website URL2022-07-07T08:41:01+02:00Delaigue OlivierUpdate the sunshine website URLNew URL: https://sunshine.inrae.fr/New URL: https://sunshine.inrae.fr/v0.3.1