basinSample issueshttps://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues2021-08-06T13:35:57+02:00https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/19Display IGN-scan map & update IGN term of use URL2021-08-06T13:35:57+02:00Delaigue OlivierDisplay IGN-scan map & update IGN term of use URLThe following URL does not work anymore: https://depot.ign.fr/geoportail/api/develop/tech-docs-js/license.html
We have to refer to the Etalab license... https://www.etalab.gouv.fr/licence-ouverte-open-licenceThe following URL does not work anymore: https://depot.ign.fr/geoportail/api/develop/tech-docs-js/license.html
We have to refer to the Etalab license... https://www.etalab.gouv.fr/licence-ouverte-open-licencehttps://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/18Add a select list to choose the basins of an hydrological region2021-04-13T19:07:53+02:00Delaigue OlivierAdd a select list to choose the basins of an hydrological regionCreate a select list that can be used to select the basins of an hydrological region. The multiple list can use the station code.
The selection could be more specific if the user add some characters (`H`, `H3`, `H39`, etc.)Create a select list that can be used to select the basins of an hydrological region. The multiple list can use the station code.
The selection could be more specific if the user add some characters (`H`, `H3`, `H39`, etc.)https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/17Display a space separator between thousands places in numbers2020-12-21T08:40:38+01:00Delaigue OlivierDisplay a space separator between thousands places in numbersThere is no sign currently used as a separator for the sliders of the GUI. It could be a more readable to use a **space** instead of nothing.There is no sign currently used as a separator for the sliders of the GUI. It could be a more readable to use a **space** instead of nothing.https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/16Display accented characters2020-12-21T08:36:03+01:00Delaigue OlivierDisplay accented charactersAccented characters do not seem to be displayed correctly when they come from the *global.R* file despite the setting of the locale R process with the following command:
```
Sys.setlocale("LC_ALL", "fr_FR.UTF-8")
```
Maybe the followin...Accented characters do not seem to be displayed correctly when they come from the *global.R* file despite the setting of the locale R process with the following command:
```
Sys.setlocale("LC_ALL", "fr_FR.UTF-8")
```
Maybe the following syntax works:
```
Sys.setlocale("LC_ALL", "fr_FR.utf8)
```
Because in the help page of the `Sys.setlocale()` function it is written:
```
Sys.setlocale("LC_TIME", "de_DE") # Many Unix-alikes
Sys.setlocale("LC_TIME", "de_DE.UTF-8") # Linux, macOS, other Unix-alikes
Sys.setlocale("LC_TIME", "de_DE.utf8") # some Linux versions
```https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/15Not all basins are selected when applying the widest ranges of values for eac...2020-04-29T10:48:57+02:00Genot BenoitNot all basins are selected when applying the widest ranges of values for each criterion (3631 instead of 3632).Genot BenoitGenot Benoithttps://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/14Add table containing bibliographic references2020-04-29T10:44:08+02:00Delaigue OlivierAdd table containing bibliographic references@benoit.genot, we can add a table with these following columns:
- short citation reference (i.e. "Author et al. 2020" ; hyperlink to doir.org, HAL or webGR [if PhD thesis not on HAL])
- time step ("monthly", "daily", "hourly" and/or "< h...@benoit.genot, we can add a table with these following columns:
- short citation reference (i.e. "Author et al. 2020" ; hyperlink to doir.org, HAL or webGR [if PhD thesis not on HAL])
- time step ("monthly", "daily", "hourly" and/or "< hourly")
Maybe we could replace the short citation reference by two columns in order to be able to sort the table by year. Where should we put the hyperlink in this case?
- authors
- yearhttps://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/13Location of package loading2020-04-10T11:24:20+02:00Delaigue OlivierLocation of package loadingIn the **ui** file, the following packages are loaded :
* `shiny`
* `shinydashboard`
In the **global** file, the following packages are loaded :
* `shiny`
* `shinydashboard`
* `plotly`
Isn't it enough that they appear in the **global**...In the **ui** file, the following packages are loaded :
* `shiny`
* `shinydashboard`
In the **global** file, the following packages are loaded :
* `shiny`
* `shinydashboard`
* `plotly`
Isn't it enough that they appear in the **global** file?
In addition, the `sf`, `leaflet` and `DT` packages are not loaded.
@benoit.genot, do you know what the recommendations are?https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/12Choice of graphical representation of distributions2020-06-03T05:42:09+02:00Delaigue OlivierChoice of graphical representation of distributions@benoit.genot, I tested the interface with all available basins (> 4000).
When you manipulate the interface, the reaction times seem correct at first. But as soon as you play with it a little, troubles start to appear. Maybe it's due to ...@benoit.genot, I tested the interface with all available basins (> 4000).
When you manipulate the interface, the reaction times seem correct at first. But as soon as you play with it a little, troubles start to appear. Maybe it's due to memory management.
When a large number of basins are selected and you move the sliders several times, after a while it takes a long time to update the graphs. Moreover, when zooming on a graph, it makes troubles when the user the double click in order to return to the initial the plotting region.
Perhaps it would be better to draw histograms rather than empirical cumulative distributions. The disadvantage is that it will probably no longer be possible to identify the basins on the graphs (thanks to a label, see screenshot below).
When there are many basins, one possibility is not to plot the the whole set of points that are in the middle of the distribution. In this case, the possibility to zoom in on the graphs loses its interest.
@charles.perrin, what do you think about?
Code modifications to run the test:
```
#! basin contours
pathCont <- file.path(pathSrc, "contours/4190BVs_FRANCE_WGS84_2018_simple")
```
```
#! criteria : file with criteria for each basin
criteria <- read.table(file = pathCrit, header = TRUE, sep = ";",
stringsAsFactors = FALSE, encoding = "UTF-8", quote = "",
comment.char = "")
criteria[!complete.cases(criteria), -1] <- criteria[1, -1]
```
![basinSample_2020-04-07_09-56-26](/uploads/e8b31b25f0f1aa65d2e953a9a9ade219/basinSample_2020-04-07_09-56-26.png)https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/11Updating when proxy's invoke method is used2020-04-04T11:10:33+02:00Delaigue OlivierUpdating when proxy's invoke method is used@benoit.genot why all the computations are in inside the observeEvent?
Shouldn't there be only proxy method commands inside the observeEvent? Otherwise all the computations are redone each time a slider value changed, therefore the func...@benoit.genot why all the computations are in inside the observeEvent?
Shouldn't there be only proxy method commands inside the observeEvent? Otherwise all the computations are redone each time a slider value changed, therefore the functions that update only a part of the data are useless, isn't it?https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/10Update of the station list table when the proxy's invoke method is used2020-04-19T10:20:01+02:00Delaigue OlivierUpdate of the station list table when the proxy's invoke method is usedIt seems that the table containing the list of stations is not updated when no station is selected.
![basinSample_2020-04-04_10-15-43](/uploads/ec26e38b51343e9b66e9f9d0cc7cb48b/basinSample_2020-04-04_10-15-43.png)It seems that the table containing the list of stations is not updated when no station is selected.
![basinSample_2020-04-04_10-15-43](/uploads/ec26e38b51343e9b66e9f9d0cc7cb48b/basinSample_2020-04-04_10-15-43.png)https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/9Update of the plotly graphs when the proxy's invoke method is used2020-04-06T09:12:12+02:00Delaigue OlivierUpdate of the plotly graphs when the proxy's invoke method is usedThere is a problem with the selection of basins.
Not all basins are drawn on the graphs.
![basinSample_screenshot_2020-04-03_11-44-09](/uploads/b6fc8853a574ab7b72aea788a0bf28fa/basinSample_screenshot_2020-04-03_11-44-09.png)
![basinSamp...There is a problem with the selection of basins.
Not all basins are drawn on the graphs.
![basinSample_screenshot_2020-04-03_11-44-09](/uploads/b6fc8853a574ab7b72aea788a0bf28fa/basinSample_screenshot_2020-04-03_11-44-09.png)
![basinSample_screenshot_2020-04-03_11-44-23](/uploads/f725dd082f0e8fef693d08693576baf7/basinSample_screenshot_2020-04-03_11-44-23.png)https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/8Update plots with plotlyProxy2020-04-03T11:47:51+02:00Genot BenoitUpdate plots with plotlyProxyCurrently, the plots are entirely redraw each time that user play with sliders. It could be more efficient drawing the plots with grey points at the beginning and then only add blue points corresponding to the basins selection when slide...Currently, the plots are entirely redraw each time that user play with sliders. It could be more efficient drawing the plots with grey points at the beginning and then only add blue points corresponding to the basins selection when sliders are moved.Genot BenoitGenot Benoithttps://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/7Sliders in a logarithmic scale2020-04-10T08:38:23+02:00Delaigue OlivierSliders in a logarithmic scaleIt would be a good idea if the sliders are in a logarithmic scale, because most of the basins are in the first part of the range for most of the criteria.It would be a good idea if the sliders are in a logarithmic scale, because most of the basins are in the first part of the range for most of the criteria.https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/6Time period selection2020-04-20T09:03:53+02:00Delaigue OlivierTime period selectionIt would probably be a good idea to add a slider to select the period over which certain variables are calculated (average flow, average precipitation, etc.).
This requires the input data to be formatted differently in order to have acce...It would probably be a good idea to add a slider to select the period over which certain variables are calculated (average flow, average precipitation, etc.).
This requires the input data to be formatted differently in order to have access to the annual statistics.https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/5Loop on criteria2020-03-25T12:26:14+01:00Delaigue OlivierLoop on criteriaSince the codes of the ui file and the server file are redundant, it is probably a good idea to make loops on each of the criteria if the graphical representation is the same.Since the codes of the ui file and the server file are redundant, it is probably a good idea to make loops on each of the criteria if the graphical representation is the same.https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/4Computation of quantiles2020-03-25T03:48:41+01:00Delaigue OlivierComputation of quantilesIn the code of the "global" file, we compute the quantiles from 1 to 99, but in the "server" file, we take the values 1, 26, 51, 76 and 101, which is not coherent, isn't it?
Why don't we calculate the quantiles between 0 and 100?In the code of the "global" file, we compute the quantiles from 1 to 99, but in the "server" file, we take the values 1, 26, 51, 76 and 101, which is not coherent, isn't it?
Why don't we calculate the quantiles between 0 and 100?Genot BenoitGenot Benoithttps://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/3Labels of box and sliders2020-04-20T09:04:28+02:00Delaigue OlivierLabels of box and slidersThe texts of the boxes and sliders must be improved (capital letters, units, complete texts, etc.).
The unit of the area should be km2 and not m2.The texts of the boxes and sliders must be improved (capital letters, units, complete texts, etc.).
The unit of the area should be km2 and not m2.https://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/2Update URL links with INRAE2020-03-23T15:35:11+01:00Delaigue OlivierUpdate URL links with INRAELinks from old IRSTEA URLs should be replaced by INRAE onesLinks from old IRSTEA URLs should be replaced by INRAE oneshttps://gitlab.irstea.fr/HYCAR-Hydro/basinsample/-/issues/1Add other criterion sliders2020-03-25T09:09:47+01:00Delaigue OlivierAdd other criterion slidersIt is necessary to complete the list of criteria to select the basin sampleIt is necessary to complete the list of criteria to select the basin sample