From a81bf8f4e452a9471e64519dd7c4a7c369d19209 Mon Sep 17 00:00:00 2001
From: Thibault Hallouin <thibault.hallouin@inrae.fr>
Date: Mon, 16 Jan 2023 16:56:34 +0100
Subject: [PATCH] fix broadcasting problem in calculating alerts
only showing up when multiple lead times provided
---
include/evalhyd/detail/probabilist/contingency.hpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/evalhyd/detail/probabilist/contingency.hpp b/include/evalhyd/detail/probabilist/contingency.hpp
index 771f768..533e4ba 100644
--- a/include/evalhyd/detail/probabilist/contingency.hpp
+++ b/include/evalhyd/detail/probabilist/contingency.hpp
@@ -56,9 +56,10 @@ namespace evalhyd
auto alert_lvl = xt::arange<double>(double(n_mbr + 1));
// determine whether forecast yield alert
- return sum_f_k >=
- xt::view(alert_lvl, xt::newaxis(), xt::newaxis(),
- xt::all(), xt::newaxis(), xt::newaxis());
+ return xt::view(sum_f_k, xt::all(), xt::all(), xt::newaxis(),
+ xt::all(), xt::all())
+ >= xt::view(alert_lvl, xt::newaxis(), xt::newaxis(),
+ xt::all(), xt::newaxis(), xt::newaxis());
}
/// Determine hits ('a' in contingency table).
--
GitLab