From f58170a5fcaeae1143bd1a626453722306609c00 Mon Sep 17 00:00:00 2001
From: Thibault Hallouin <thibault.hallouin@inrae.fr>
Date: Wed, 29 Mar 2023 19:07:39 +0200
Subject: [PATCH] fix mistake in computation of CRPS_FROM_ECDF
---
include/evalhyd/detail/probabilist/cdf.hpp | 7 ++++---
tests/expected/evalp/CRPS_FROM_ECDF.csv | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/evalhyd/detail/probabilist/cdf.hpp b/include/evalhyd/detail/probabilist/cdf.hpp
index 1f5489e..e0cf0b1 100644
--- a/include/evalhyd/detail/probabilist/cdf.hpp
+++ b/include/evalhyd/detail/probabilist/cdf.hpp
@@ -107,16 +107,17 @@ namespace evalhyd
);
// compute crps as difference between the quadratic CDFs
- auto p_i_2 = xt::eval(
+ auto p_i = xt::eval(
xt::view(
- xt::square(xt::arange<double>(n_mbr + 1) / n_mbr),
+ xt::arange<double>(n_mbr + 1) / n_mbr,
xt::all(), xt::newaxis(), xt::newaxis(),
xt::newaxis()
)
);
auto crps_from_ecdf = xt::sum(
- (alpha_i * p_i_2) + (beta_i * (1 - p_i_2)),
+ (alpha_i * xt::square(p_i))
+ + (beta_i * xt::square(1 - p_i)),
0
);
diff --git a/tests/expected/evalp/CRPS_FROM_ECDF.csv b/tests/expected/evalp/CRPS_FROM_ECDF.csv
index 13832cc..a639c99 100644
--- a/tests/expected/evalp/CRPS_FROM_ECDF.csv
+++ b/tests/expected/evalp/CRPS_FROM_ECDF.csv
@@ -1 +1 @@
-271.9578705197483
+262.615225902479
--
GitLab