From fff308517dbcd4fa1f47b64a75591eaafdcfa8d1 Mon Sep 17 00:00:00 2001
From: Thibault Hallouin <thibault.hallouin@inrae.fr>
Date: Mon, 12 Sep 2022 15:54:35 +0200
Subject: [PATCH] fix mistake in calculation of CRPS
---
src/probabilist/evaluator_quantiles.cpp | 2 +-
tests/test_probabilist.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/probabilist/evaluator_quantiles.cpp b/src/probabilist/evaluator_quantiles.cpp
index a92c76a..b0dc6f6 100644
--- a/src/probabilist/evaluator_quantiles.cpp
+++ b/src/probabilist/evaluator_quantiles.cpp
@@ -90,7 +90,7 @@ namespace evalhyd
// integrate with trapezoidal rule
crps = xt::view(
// xt::trapz(y, dx=1/(n+1), axis=0)
- xt::trapz(qs, 1./(double(n_mbr) + .1), 0),
+ xt::trapz(qs, 1./(double(n_mbr) + 1.), 0),
xt::newaxis(), xt::all()
);
}
diff --git a/tests/test_probabilist.cpp b/tests/test_probabilist.cpp
index ec65961..5906cbc 100644
--- a/tests/test_probabilist.cpp
+++ b/tests/test_probabilist.cpp
@@ -115,7 +115,7 @@ TEST(ProbabilistTests, TestQuantiles)
// Continuous ranked probability scores
xt::xtensor<double, 3> crps =
- {{{ 257.412129}}};
+ {{{252.956919}}};
EXPECT_TRUE(xt::allclose(metrics[1], crps));
}
--
GitLab