Commit e8db0dfb authored by Mathias Chouet's avatar Mathias Chouet 🍝
Browse files

Remove TODOs

parent d2402354
// variables
$navbar_height: 54px; // @TODO not really generic
$navbar_height: 54px; // not really generic
// rules
......
......@@ -277,7 +277,7 @@ export class DialogEditParamValuesComponent implements OnInit {
if (e.length > 0) {
// ensure decimal separator is "." for Number()
if (this.decimalSeparator !== ".") {
const re = new RegExp(this.decimalSeparator, "g"); // @TODO remove "g" ?
const re = new RegExp(this.decimalSeparator, "g");
e = e.replace(re, ".");
}
vals.push(Number(e));
......@@ -304,7 +304,7 @@ export class DialogEditParamValuesComponent implements OnInit {
if (e.length > 0) { // should always be true as separator might be several characters long
// ensure decimal separator is "." for Number()
if (this.decimalSeparator !== ".") {
const re = new RegExp(this.decimalSeparator, "g"); // @TODO remove "g" ?
const re = new RegExp(this.decimalSeparator, "g");
e = e.replace(re, ".");
}
// 2.1 check it is a valid Number
......
......@@ -82,7 +82,7 @@ export class FieldsetContainerComponent implements DoCheck, AfterViewInit {
}
if (clone) {
// replace in-place to change properties (overkill)
// @TODO why only those two ? loop over all properties in a generic way ?
// @WTF why only those two ?
newFs.setPropValue("structureType", after.properties.getPropValue("structureType"));
newFs.setPropValue("loiDebit", after.properties.getPropValue("loiDebit"));
// copy param values
......
......@@ -57,7 +57,7 @@ export class MacrorugoCompoundResultsTableComponent extends ResultsComponentDire
// lines 1 - n-1 (aprons)
for (let i = 0; i < pr.childrenResults.length; i++) {
// @TODO protect loop contents with if(vCalc) ? Will hide erroneous apron results..
// protect loop contents with if(vCalc) ? Will hide erroneous apron results..
const res = pr.childrenResults[i].resultElements[vi].values;
const nub = (pr.childrenResults[i].sourceNub as MacroRugo);
// does ZF1 or B vary ?
......
......@@ -116,7 +116,7 @@ export class ModulesDiagramComponent implements AfterContentInit, AfterViewCheck
public ngAfterContentInit(): void {
this.error = false;
mermaid.initialize({
// theme: "forest", // @TODO thème Irstea !
// theme: "forest"
flowchart: {
curve: "basis"
}
......
......@@ -102,7 +102,7 @@ export class PabTableComponent implements AfterViewInit, OnInit {
return this.hasModel(cell) && ! this.isSelect(cell);
}
/** returns true if the cell is a select box @TODO rename */
/** returns true if the cell is a select box */
public isSelect(cell: any): boolean {
return this.hasModel(cell) && (cell.options !== undefined);
}
......
......@@ -66,7 +66,6 @@ export class I18nService extends Observable implements Observer {
// did language change ?
if (this._currentLanguage !== code) {
this._currentLanguage = code;
// @TODO keep old messages for backup-language mechanisms ?
this._Messages = undefined;
// reload all messages
const that = this;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment