From 56b35a51d1e909e7e3eb3123cec9076677090c2e Mon Sep 17 00:00:00 2001
From: Delaigue Olivier <olivier.delaigue@irstea.priv>
Date: Thu, 23 May 2019 15:19:33 +0200
Subject: [PATCH] v1.3.2.8 NEW: PEdaily_Oudin is deprecated
---
DESCRIPTION | 2 +-
NEWS.rmd | 11 ++++++++---
R/PEdaily_Oudin.R | 7 +++++++
3 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/DESCRIPTION b/DESCRIPTION
index d2c5fa08..729f9b3f 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,7 +1,7 @@
Package: airGR
Type: Package
Title: Suite of GR Hydrological Models for Precipitation-Runoff Modelling
-Version: 1.3.2.7
+Version: 1.3.2.8
Date: 2019-05-23
Authors@R: c(
person("Laurent", "Coron", role = c("aut", "trl"), comment = c(ORCID = "0000-0002-1503-6204")),
diff --git a/NEWS.rmd b/NEWS.rmd
index 2789188e..d80af8b6 100644
--- a/NEWS.rmd
+++ b/NEWS.rmd
@@ -14,7 +14,7 @@ output:
-### 1.3.2.7 Release Notes (2019-05-22)
+### 1.3.2.8 Release Notes (2019-05-23)
#### New features
@@ -23,12 +23,17 @@ output:
- Added <code>RunModel_CemaNeigeGR4H()</code> function to run the hourly model GR4H with the CemaNeige module.
-- Added <code>PE_Oudin()</code> function to compute Oudin's potential evapotranspiration for hourly or daily tim steps.
+- Added <code>PE_Oudin()</code> function to compute Oudin's potential evapotranspiration for hourly or daily time steps.
+
+
+#### Deprecated and defunct
+
+- The <code>PEdaily_Oudin()</code> function is deprecated and his use has been replaced by the use of <code>PE_Oudin()</code>.
#### Major user-visible changes
-- <code>plot.OutputsModel()</code> can now draw PET or error time series if the <code>which</code> argument is set to <code>"all"</code> or <code>"PotEvap"</code> or <code>"Error"</code>.
+- <code>plot.OutputsModel()</code> can now draw PE or error time series if the <code>which</code> argument is set to <code>"all"</code> or <code>"PotEvap"</code> or <code>"Error"</code>.
- <code>plot.OutputsModel()</code> now allows new values for the which argument: <code>"all"</code> corresponds to all graphs, <code>"synth"</code> corresponds to the main graphs (default value; corresponding to <code>"all"</code> in the previous versions of the package) (i.e. <code>c("Precip", "Temp", "SnowPack", "Flows", "Regime", "CumFreq", "CorQQ")</code>), <code>"ts"</code> corresponds to the time series graphs (i.e. <code>c("Precip", "PotEvap", "Temp", "SnowPack", "Flows")</code>) and "perf" corresponds to the performance graphs (i.e. <code>c("Error", "Regime", "CumFreq", "CorQQ")</code>).
diff --git a/R/PEdaily_Oudin.R b/R/PEdaily_Oudin.R
index 4883dd34..b71ac999 100644
--- a/R/PEdaily_Oudin.R
+++ b/R/PEdaily_Oudin.R
@@ -1,5 +1,12 @@
PEdaily_Oudin <- function(JD, Temp, LatRad, Lat, LatUnit = c("rad", "deg")) {
+ ## ---------- deprecated function
+
+ .Deprecated(new = "PEdaily_Oudin", package = NULL,
+
+ msg = "deprecated function\nplease, use PE_Oudin() instead",
+
+ old = as.character(sys.call(sys.parent()))[1L])
## ---------- check arguments
--
GitLab