From 605e6c2f007247a236c7a3efbd101bfcf07db434 Mon Sep 17 00:00:00 2001
From: Dorchies David <david.dorchies@irstea.fr>
Date: Sat, 9 Jan 2021 18:02:56 +0100
Subject: [PATCH] ci: error check on fake wrong ConvertFun for SeriesAggreg
tests
Refs #82
---
tests/testthat/helper_seriesaggreg.R | 3 ---
tests/testthat/test-SeriesAggreg.R | 8 --------
2 files changed, 11 deletions(-)
delete mode 100644 tests/testthat/helper_seriesaggreg.R
diff --git a/tests/testthat/helper_seriesaggreg.R b/tests/testthat/helper_seriesaggreg.R
deleted file mode 100644
index e09bc4a1..00000000
--- a/tests/testthat/helper_seriesaggreg.R
+++ /dev/null
@@ -1,3 +0,0 @@
-sample2 <- function(x) {sample(x, 2)}
-
-stringFunction <- function(x) {format(max(x))}
diff --git a/tests/testthat/test-SeriesAggreg.R b/tests/testthat/test-SeriesAggreg.R
index ce5cf876..7ec93199 100644
--- a/tests/testthat/test-SeriesAggreg.R
+++ b/tests/testthat/test-SeriesAggreg.R
@@ -230,11 +230,3 @@ test_that("SeriesAggreg should work with ConvertFun 'min', 'max' and 'median'",
}
lapply(c("max", "min", "median"), function(x) {test_ConvertFunRegime(Qls, x, "%Y")})
})
-
-test_that("Error on wrong aggregation function", {
- Qls <- BasinObs[, c("DatesR", "Qls")]
- expect_error(SeriesAggreg(Qls, "%Y", ConvertFun = "sample2"),
- regexp = "should be of length 1")
- expect_error(SeriesAggreg(Qls, "%Y", ConvertFun = "stringFunction"),
- regexp = "should be numeric")
-})
--
GitLab