diff --git a/R/Calibration.GRiwrmInputsModel.R b/R/Calibration.GRiwrmInputsModel.R index da64df923296b7ae579fe0f0979737e857399bbb..e91a2d49b6cb2f35c2af3eb798dbb702ca3ea923 100644 --- a/R/Calibration.GRiwrmInputsModel.R +++ b/R/Calibration.GRiwrmInputsModel.R @@ -31,7 +31,7 @@ Calibration.GRiwrmInputsModel <- function(InputsModel, OutputsModel <- list() class(OutputsModel) <- append("GRiwrmOutputsModel", class(OutputsModel)) - b <- sapply(InputsModel, function(IM) !IM$isUngauged) + b <- sapply(InputsModel, function(IM) !IM$inUngaugedCluster) gaugedIds <- names(b[b]) for (id in gaugedIds) { diff --git a/R/CreateInputsCrit.GRiwrmInputsModel.R b/R/CreateInputsCrit.GRiwrmInputsModel.R index bc234ed35b9f11d6c8f3616119042a2115c3902d..c8b0e754a4fa362a3567cf4501d8e84dd9c062c2 100644 --- a/R/CreateInputsCrit.GRiwrmInputsModel.R +++ b/R/CreateInputsCrit.GRiwrmInputsModel.R @@ -59,7 +59,7 @@ CreateInputsCrit.GRiwrmInputsModel <- function(InputsModel, "\nIf possible, set this apriori id as the donor of the node \"", id,"\" to force the calibration sequence order") } - if (InputsModel[[AprioriIds[id]]]$isUngauged & + if (InputsModel[[AprioriIds[id]]]$inUngaugedCluster & InputsModel[[AprioriIds[id]]]$gaugedId == id) { stop("'AprioriIds': the node \"", AprioriIds[id], "\" is ungauged, use a gauged node instead") diff --git a/R/CreateInputsModel.GRiwrm.R b/R/CreateInputsModel.GRiwrm.R index 2d60245353a1590a50e4282d28dfd279e6bdd573..387bfee26639d1149c443348ebd5db630ea5bf7d 100644 --- a/R/CreateInputsModel.GRiwrm.R +++ b/R/CreateInputsModel.GRiwrm.R @@ -331,10 +331,14 @@ CreateOneGRiwrmInputsModel <- function(id, griwrm, DatesR, ..., Qobs, Qmin, Qrel # Add the model function InputsModel$FUN_MOD <- FUN_MOD featModel <- .GetFeatModel(InputsModel, IsHyst) - InputsModel$isUngauged <- node$id != node$donor && - isNodeDownstream(griwrm, id, node$donor) - InputsModel$isReceiver <- node$id != node$donor && - !isNodeDownstream(griwrm, id, node$donor) + # inUngaugedCluster: Ungauged node with downstream donor + # including reservoirs between ungauged nodes and donor + InputsModel$inUngaugedCluster <- (node$model == "Ungauged" || np$Reservoir) && + node$id != node$donor && + isNodeDownstream(griwrm, id, node$donor) + # isReceiver: Ungauged node with not downstream donor + InputsModel$isReceiver <- node$model == "Ungauged" && + !isNodeDownstream(griwrm, id, node$donor) InputsModel$gaugedId <- node$donor InputsModel$hasUngaugedNodes <- hasUngaugedNodes(id, griwrm) InputsModel$model <-