airGRiwrm issueshttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues2022-08-29T16:35:57+02:00https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/93Regularisation: check if current node and a priori node use the same model2022-08-29T16:35:57+02:00Dorchies DavidRegularisation: check if current node and a priori node use the same modelActually this check is not applied and can lead to unexpected behaviours.
Throw a fatal error if models are different.
Same model means exactly the same model: e.g. RunModel_GR4J and RunModel_CemaneigeGR4J are different models and rais...Actually this check is not applied and can lead to unexpected behaviours.
Throw a fatal error if models are different.
Same model means exactly the same model: e.g. RunModel_GR4J and RunModel_CemaneigeGR4J are different models and raises an error.v0.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/50Test fail after airGR update on outputing warm-up Qsim2021-07-09T18:56:19+02:00Dorchies DavidTest fail after airGR update on outputing warm-up QsimAfter the merge HYCAR-Hydro/airgr!49, a series of tests are failing:
```
── 1. Failure: RunModelSupervisor with no regulation should returns same results
OM_Supervisor[["54057"]]$Qsim not equal to OM_GriwrmInputs[["54057"]]$Qsim.
names ...After the merge HYCAR-Hydro/airgr!49, a series of tests are failing:
```
── 1. Failure: RunModelSupervisor with no regulation should returns same results
OM_Supervisor[["54057"]]$Qsim not equal to OM_GriwrmInputs[["54057"]]$Qsim.
names for current but not for target
── 2. Failure: RunModelSupervisor with two regulations that cancel each other ou
OM_Supervisor[["54057"]]$Qsim not equal to OM_GriwrmInputs[["54057"]]$Qsim.
names for current but not for target
── 3. Failure: RunModelSupervisor with multi time steps controller, two regulati
OM_Supervisor[["54057"]]$Qsim not equal to OM_GriwrmInputs[["54057"]]$Qsim.
names for current but not for target
══ testthat results ═══════════════════════════════════════════════════════════
[ OK: 9 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 3 ]
1. Failure: RunModelSupervisor with no regulation should returns same results as RunModel.GRiwrmInputsModel (@test-RunModel.R#50)
2. Failure: RunModelSupervisor with two regulations that cancel each other out should returns same results as RunModel.GRiwrmInputsModel (@test-RunModel.R#84)
3. Failure: RunModelSupervisor with multi time steps controller, two regulations in 1 centralised controller that cancel each other out should returns same results as RunModel.GRiwrmInputsModel (@test-RunModel.R#98)
Error: testthat unit tests failed
Execution halted
1 error ✖ | 1 warning ✖ | 1 note ✖
```v0.6.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/35Vignettes: working directory instability2021-04-15T10:13:55+02:00Dorchies DavidVignettes: working directory instabilityOn my session of Rstudio, the working directory is the one of the project directory on vignette 1 and it is the subdirectory "vignettes" on vignette 2. It leads to severe issues with the version of the files we're suppose to write and read.On my session of Rstudio, the working directory is the one of the project directory on vignette 1 and it is the subdirectory "vignettes" on vignette 2. It leads to severe issues with the version of the files we're suppose to write and read.v0.6.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/4Overriding airGR CreateInputsModel, RunOptions and RunModel2020-05-26T17:34:44+02:00Dorchies DavidOverriding airGR CreateInputsModel, RunOptions and RunModelInstead of running `CreateInputsModel` and `RunOptions` inside the SD `RunModel` (see: https://gitlab.irstea.fr/in-wop/griwrm/-/blob/3a1003f6ff49e3b36542bdd763c8efe5814e1a05/R/RunModelGriwrm.R#L101). Launch RunOptions once and store all ...Instead of running `CreateInputsModel` and `RunOptions` inside the SD `RunModel` (see: https://gitlab.irstea.fr/in-wop/griwrm/-/blob/3a1003f6ff49e3b36542bdd763c8efe5814e1a05/R/RunModelGriwrm.R#L101). Launch RunOptions once and store all options in a list of sub-basins in order to get a RunModel and Calibration more coherent with the airGR interface.
Use S3 class methods as proposed in https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/issues/14#note_20100 for overriding airGR function depending of the class object used as first argument of the function.Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/3Calibration of semi-distributed model2020-06-06T17:25:09+02:00Dorchies DavidCalibration of semi-distributed modelAs in #2 for running the model, try to run Michel's calibration on the whole naturalised Seine river basin.As in #2 for running the model, try to run Michel's calibration on the whole naturalised Seine river basin.v0.2Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/2Scheduling airGR model runs2020-05-25T16:27:49+02:00Dorchies DavidScheduling airGR model runsRun models in upstream to downstream order by sorting and formatting data for airGR.Run models in upstream to downstream order by sorting and formatting data for airGR.Dorchies DavidDorchies David