airGRiwrm issueshttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues2024-02-13T16:42:11+01:00https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/137Update HAL URL to pass cran checks2024-02-13T16:42:11+01:00Delaigue OlivierUpdate HAL URL to pass cran checksThe HAL archive URL has been modified. The address `archives-ouvertes.fr` is automatically redirected to `hal.science`. However, the CRAN does not allowed redirection. So we hat to use `hal.science` in the following files.
- R/Calibrat...The HAL archive URL has been modified. The address `archives-ouvertes.fr` is automatically redirected to `hal.science`. However, the CRAN does not allowed redirection. So we hat to use `hal.science` in the following files.
- R/Calibration.GriwrmInputsModel.R
- vignettes/airGRiwrm.bibv0.6.2https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/133Improve RunModel documentation2023-05-31T09:42:40+02:00Dorchies DavidImprove RunModel documentationAdd details on returned value:
- format of the attribute Qm3s
- data added compared to airGR: Qnat, Qdiv, Qdiv_m3
Improve examples:
- margin of the plot in the final example (Y-axis label is overflowing)
- use dotted line for the minimu...Add details on returned value:
- format of the attribute Qm3s
- data added compared to airGR: Qnat, Qdiv, Qdiv_m3
Improve examples:
- margin of the plot in the final example (Y-axis label is overflowing)
- use dotted line for the minimum flow in the final plotv0.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/119Update package citation reference2023-04-19T10:48:50+02:00Dorchies DavidUpdate package citation referenceUse the DOI provided by Inrae.
Use the Hubeau citation file as template: https://github.com/inrae/hubeau/blob/master/inst/CITATIONUse the DOI provided by Inrae.
Use the Hubeau citation file as template: https://github.com/inrae/hubeau/blob/master/inst/CITATIONv0.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/100Improve Supervisor documentation2022-10-31T08:06:58+01:00Dorchies DavidImprove Supervisor documentationAdd a complete original example for the documentation of the Supervisor suite (`CreateSupervisor`, `CreateController`, `RunModelSupervisor`)Add a complete original example for the documentation of the Supervisor suite (`CreateSupervisor`, `CreateController`, `RunModelSupervisor`)v0.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/97Add example of management of NAs in controllers2022-09-16T12:32:54+02:00Dorchies DavidAdd example of management of NAs in controllersWrite an example of a fallback order `U` in case of `Y` of a controller is providing a NA value.Write an example of a fallback order `U` in case of `Y` of a controller is providing a NA value.Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/82Website : Remove french comments2022-07-18T21:30:23+02:00Delaigue OlivierWebsite : Remove french commentsThere is still a French comment (from Guillaume?) in the [Severn_01: Set up of a semi-distributed GR model network page](https://airgriwrm.g-eau.fr/articles/V01_Structure_SD_model.html])
```r
nodes <- Severn$BasinsInfo[, c("gauge_id", "...There is still a French comment (from Guillaume?) in the [Severn_01: Set up of a semi-distributed GR model network page](https://airgriwrm.g-eau.fr/articles/V01_Structure_SD_model.html])
```r
nodes <- Severn$BasinsInfo[, c("gauge_id", "downstream_id", "distance_downstream", "area")]
nodes$distance_downstream <- nodes$distance_downstream #je ne comprends pas cette ligne, elle semble inutile
nodes$model <- "RunModel_GR4J"
```https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/81Website: Avoid overlaps between text and figures in rticles2022-07-18T19:35:37+02:00Delaigue OlivierWebsite: Avoid overlaps between text and figures in rticlesThe figure ovelaps the text in the [Seine_01: Structuration of a semi-distributed GR4J model network](https://airgriwrm.g-eau.fr/articles/seinebasin/V01_First_network.html) article:
![image](/uploads/304808aa3b83610b1a2f4b997c01ba4a/ima...The figure ovelaps the text in the [Seine_01: Structuration of a semi-distributed GR4J model network](https://airgriwrm.g-eau.fr/articles/seinebasin/V01_First_network.html) article:
![image](/uploads/304808aa3b83610b1a2f4b997c01ba4a/image.png)https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/79Wrong file name for the "Get started" vignette2022-07-18T17:36:48+02:00Dorchies DavidWrong file name for the "Get started" vignetteThe good file name should be "airGRiwrm.Rmd" not "airgriwrm.Rmd"...The good file name should be "airGRiwrm.Rmd" not "airgriwrm.Rmd"...v0.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/77Add a main page in the package documentation2022-03-09T09:04:27+01:00Dorchies DavidAdd a main page in the package documentationJust to get an introduction in the PDF.
See https://r-pkgs.org/man.html#man-packages for execution.Just to get an introduction in the PDF.
See https://r-pkgs.org/man.html#man-packages for execution.v0.7.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/49Add an airGR galaxy tab on the website?2022-02-21T17:53:17+01:00Thirel GuillaumeAdd an airGR galaxy tab on the website?I think it would be preferable to add an airGR Galaxy tab on the airGRiwrm website, in a similar way as done in other site (e.g. https://hydrogr.github.io/airGR/). What do you think @olivier.delaigue and @david.dorchies ?I think it would be preferable to add an airGR Galaxy tab on the airGRiwrm website, in a similar way as done in other site (e.g. https://hydrogr.github.io/airGR/). What do you think @olivier.delaigue and @david.dorchies ?v0.6.0https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/45Update URLs in the DESCRIPTION file2021-12-12T18:03:32+01:00Delaigue OlivierUpdate URLs in the DESCRIPTION file```
URL: https://airgriwrm.g-eau.fr/
BugReports: https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues
``````
URL: https://airgriwrm.g-eau.fr/
BugReports: https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues
```v0.6.0https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/44Generation of the https://airgriwrm.g-eau.net site documentation2021-04-28T12:35:37+02:00Dorchies DavidGeneration of the https://airgriwrm.g-eau.net site documentationWith pkgdown!!
With integration of the formation in French and the vignettes on the Seine RiverWith pkgdown!!
With integration of the formation in French and the vignettes on the Seine Riverv0.6.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/43Review documentation for publication on CRAN2021-12-11T15:56:42+01:00Dorchies DavidReview documentation for publication on CRANv0.6.0Dorchies DavidDorchies Davidhttps://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/17Knitting vignette 01 not possible2020-12-15T15:42:22+01:00Thirel GuillaumeKnitting vignette 01 not possibleThe issue is located at line 87:
`Precip <- MergeTS(Precip, id, ts[,c("Date", "Ptot")])`
which executes line 71:
`dfOut <- merge(dfOld, dfNew, by = "DatesR", all = TRUE)`
I think that the first issue is that one of the objects does...The issue is located at line 87:
`Precip <- MergeTS(Precip, id, ts[,c("Date", "Ptot")])`
which executes line 71:
`dfOut <- merge(dfOld, dfNew, by = "DatesR", all = TRUE)`
I think that the first issue is that one of the objects does not have a `DatesR` column.
But renaming the Date column still results in a problem:
```
Error in sort.list(bx[m$xi]) : 'x' must be atomic for 'sort.list'
Have you called 'sort' on a list?
```https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/14Insufficient info for installing the package2020-12-15T15:42:23+01:00Thirel GuillaumeInsufficient info for installing the packageThe info in the `ReadMe` is not enough for installing the package, especially if the person willing to do that is a monkey-tester. :)
First, the `sd` branch of `airGR` does not exist anymore. Please replace with the `dev` branch, which...The info in the `ReadMe` is not enough for installing the package, especially if the person willing to do that is a monkey-tester. :)
First, the `sd` branch of `airGR` does not exist anymore. Please replace with the `dev` branch, which is I think the branch that contains the SD model.
Second, the instruction ``run roxygen for generating NAMESPACE file and documentation`` does not mean much for newbies. Could you be more specific with this instruction?https://gitlab.irstea.fr/in-wop/airGRiwrm/-/issues/13Replace vignette examples on Seine River by a fake example from data provided...2020-12-28T05:28:42+01:00Dorchies DavidReplace vignette examples on Seine River by a fake example from data provided by airGRData used in airGR-IWRM documentation and vignette should not depend from external sources.Data used in airGR-IWRM documentation and vignette should not depend from external sources.v0.4.0Dorchies DavidDorchies David