lidaRtRee issueshttps://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee/-/issues2021-12-08T11:54:58+01:00https://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee/-/issues/5Backward compatibility with lidR v4.0.02021-12-08T11:54:58+01:00Roussel Jean-RomainBackward compatibility with lidR v4.0.0Has you know I'm working on `lidR v4` which will no longer be based on old R spatial packages (`sp`). One consequence is that `LAS` objects will no longer have a slot `@proj4string`.
Your package stores a serialized `LAS` object in `las...Has you know I'm working on `lidR v4` which will no longer be based on old R spatial packages (`sp`). One consequence is that `LAS` objects will no longer have a slot `@proj4string`.
Your package stores a serialized `LAS` object in `las_chablais3`. This object will no longer be valid in v4 because it has a `proj4string` instead of a `crs`. You cannot yet modify your `las_chablais3` object because `lidR v4` is not released and I won't be able to release `lidR v4` because there is a backward incompatibility that triggers a warning with `R CMD check`
The easy backward/forward compatible fix is to do not serialize `LAS` object. Instead save a `las_chablais3.laz` file in `inst/extdata` and load it with `lidR::readLAS()`. In the man page change occurences of
```r
data(las_chablais3)
```
to
```r
LASfile <- system.file("extdata", "las_chablais3.laz", package="lidaRtRee")
las_chablais3 <- lidR::readLAS(LASfile)
```
By the way serialization of `LAS` object is not a good idea because it contains a `data.table` object. `data.table` are weakly serializable.
Please update `lidaRtRee` on CRAN before the release of `lidR v4`. I do no have schedules but I won't release `lidR v4` before 2022 so, it is not in a hurry. Actually I discourage you to do it has soon as possible because `lidR v4` is still in development so I may detect another problem latter.
If you want to get an eye on `lidR v4` the current state is available in the [branch v4](https://github.com/Jean-Romain/lidR/tree/v4). See also [NEWS](https://github.com/Jean-Romain/lidR/blob/v4/NEWS.md)
Cheers
PS: if you have any question please contact me by email (in French) or on github (in English). I'm unlikely to come back here. I just took the chance to open an issue here because I already have a gitlab.irstea account.https://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee/-/issues/4Names of functions and variables should respect tidyverse format2021-07-29T17:03:34+02:00Pascal ObstetarNames of functions and variables should respect tidyverse formatI add tests for all functions and rewrite functions and variables names with respect of tidyverse format.
[lidartree_R.zip](/uploads/7bce97bbd80a9e8c4814565df0c2bfb8/lidartree_R.zip)
[lidartree_tests.zip](/uploads/678229300c597a6a4c10e8...I add tests for all functions and rewrite functions and variables names with respect of tidyverse format.
[lidartree_R.zip](/uploads/7bce97bbd80a9e8c4814565df0c2bfb8/lidartree_R.zip)
[lidartree_tests.zip](/uploads/678229300c597a6a4c10e8d8cc9d8a4f/lidartree_tests.zip)https://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee/-/issues/3add Pinus uncinata PIUN in speciesColor2018-09-07T14:15:52+02:00Kunstler Georgesadd Pinus uncinata PIUN in speciesColoradd *Pinus uncinata* with abvr PIUN in speciesColor
something like salmon4?add *Pinus uncinata* with abvr PIUN in speciesColor
something like salmon4?https://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee/-/issues/2function args names and values should respect lidR standards2021-07-13T12:30:50+02:00De Boissieu Florianfunction args names and values should respect lidR standardsarguments like XYZ ReturnNumber Classification are replaced by xyz rn c in ABAModelMetrics treeExtraction etc.
It would be easier for user to use the nomenclature of lidR on which the package is based.arguments like XYZ ReturnNumber Classification are replaced by xyz rn c in ABAModelMetrics treeExtraction etc.
It would be easier for user to use the nomenclature of lidR on which the package is based.https://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee/-/issues/1install2018-05-17T16:34:11+02:00Kunstler GeorgesinstallTo install directly with devtools
```
library(devtools)
install_git("https://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee")
```To install directly with devtools
```
library(devtools)
install_git("https://gitlab.irstea.fr/jean-matthieu.monnet/lidaRtRee")
```