From 47d6b51c02e032f5ca0140cd450402fb6be8de96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guillaume=20Perr=C3=A9al?= <guillaume.perreal@irstea.fr>
Date: Tue, 28 Nov 2017 13:34:40 +0100
Subject: [PATCH] UploadController: return type hints.
---
src/Controller/UploadController.php | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/Controller/UploadController.php b/src/Controller/UploadController.php
index 2d941563..c07aa4eb 100644
--- a/src/Controller/UploadController.php
+++ b/src/Controller/UploadController.php
@@ -91,7 +91,7 @@ class UploadController extends Controller
*
* @return JsonResponse
*/
- public function createAction(Request $request)
+ public function createAction(Request $request): JsonResponse
{
$request->setRequestFormat(self::REQUEST_FORMAT);
$data = $request->request->get('file');
@@ -136,7 +136,7 @@ class UploadController extends Controller
*
* @return JsonResponse|Response
*/
- public function putContentAction(Request $request, UploadedFile $file)
+ public function putContentAction(Request $request, UploadedFile $file): Response
{
$request->setRequestFormat(self::REQUEST_FORMAT);
$this->validateCsrfToken($request);
@@ -160,7 +160,7 @@ class UploadController extends Controller
*
* @return array
*/
- protected function handleRangeHeader(Request $request)
+ protected function handleRangeHeader(Request $request): array
{
if (!$request->headers->has('Content-Range')) {
return [0, PHP_INT_MAX, true];
@@ -188,7 +188,7 @@ class UploadController extends Controller
*
* @return Response
*/
- protected function completeUpload(UploadedFileInterface $file)
+ protected function completeUpload(UploadedFileInterface $file): Response
{
try {
$this->fileManager->completed($file);
@@ -222,7 +222,7 @@ class UploadController extends Controller
*
* @return UploadedFileResponse
*/
- public function getContentAction(Request $request, UploadedFile $file)
+ public function getContentAction(Request $request, UploadedFile $file): UploadedFileResponse
{
$this->validateCsrfToken($request);
@@ -245,7 +245,7 @@ class UploadController extends Controller
*
* @return JsonResponse
*/
- public function deleteAction(Request $request, UploadedFile $file)
+ public function deleteAction(Request $request, UploadedFile $file): JsonResponse
{
$request->setRequestFormat(self::REQUEST_FORMAT);
@@ -261,7 +261,7 @@ class UploadController extends Controller
*
* @throws HttpException
*/
- protected function validateCsrfToken(Request $request)
+ protected function validateCsrfToken(Request $request): void
{
$token = $this->csrfTokenManager->getToken($request->query->get('token'));
if (!$this->csrfTokenManager->isTokenValid($token)) {
@@ -277,7 +277,7 @@ class UploadController extends Controller
*
* @return JsonResponse
*/
- protected function createResponse($status = Response::HTTP_OK, $message = 'OK', array $data = [], array $headers = [])
+ protected function createResponse($status = Response::HTTP_OK, $message = 'OK', array $data = [], array $headers = []): JsonResponse
{
$data['status'] = $status;
$data['message'] = $message;
--
GitLab