From dceb9d80e93231a5eee989ceb93f7febdfb0d3c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guillaume=20Perr=C3=A9al?= <guillaume.perreal@irstea.fr>
Date: Thu, 29 Nov 2018 16:57:19 +0100
Subject: [PATCH] Corrections PHPMD.
---
src/Metadata/PropertyMetadataFactory.php | 11 +++++------
src/Models/ClassInfo.php | 3 +++
src/Models/PHPClass.php | 2 +-
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/Metadata/PropertyMetadataFactory.php b/src/Metadata/PropertyMetadataFactory.php
index a6acda8..823aab2 100644
--- a/src/Metadata/PropertyMetadataFactory.php
+++ b/src/Metadata/PropertyMetadataFactory.php
@@ -47,9 +47,6 @@ class PropertyMetadataFactory
/** @var ClassName */
private $resource;
- /** @var bool */
- private $normalization;
-
/** @var string */
private $mode;
@@ -89,9 +86,11 @@ class PropertyMetadataFactory
}
/**
- * @param ClassName $class
- * @param string $propertyName
- * @param APIPropertyMetadata $propertyMeta
+ * @param ClassName $class
+ * @param string $propertyName
+ *
+ * @throws ResourceClassNotFoundException
+ * @throws \ApiPlatform\Core\Exception\PropertyNotFoundException
*
* @return PropertyMetadata
*/
diff --git a/src/Models/ClassInfo.php b/src/Models/ClassInfo.php
index 669d828..b9994b3 100644
--- a/src/Models/ClassInfo.php
+++ b/src/Models/ClassInfo.php
@@ -168,6 +168,8 @@ final class ClassInfo implements ClassName
/**
* @param ClassInfo $child
+ *
+ * @SuppressWarnings(PHPMD.UnusedPrivateMethod)
*/
private function addChild(ClassInfo $child): void
{
@@ -359,6 +361,7 @@ final class ClassInfo implements ClassName
* Get properties.
*
* @return HasName[]
+ * @SuppressWarnings(PHPMD.UnusedPrivateMethod)
*/
private function getAllConcreteProperties(): array
{
diff --git a/src/Models/PHPClass.php b/src/Models/PHPClass.php
index 69fbee8..55d8baa 100644
--- a/src/Models/PHPClass.php
+++ b/src/Models/PHPClass.php
@@ -121,7 +121,7 @@ final class PHPClass implements ClassName
if (!preg_match('/^\\\\?((?:\w+\\\\)*)(\w+)$/i', $name, $groups)) {
throw new InvalidArgumentException("Invalid PHP class name: $name");
}
- [, $namespace, $baseName] = $groups;
+ list(, $namespace, $baseName) = $groups;
$instances[$name] = new self($namespace, $baseName);
}
--
GitLab