From 58daf689bdaba3cfb5a96b0beb5102f70a751379 Mon Sep 17 00:00:00 2001
From: Pierre-Antoine Rouby <pierre-antoine.rouby@inrae.fr>
Date: Fri, 15 Sep 2023 10:56:41 +0200
Subject: [PATCH] pamhyr: Apply some change from paper simhydro 2023 patch.

---
 src/Model/Stricklers/Stricklers.py        |  2 +-
 src/View/BoundaryCondition/translate.py   |  6 +-
 src/View/Geometry/PlotAC.py               | 10 +--
 src/View/Geometry/Window.py               |  2 +-
 src/View/Geometry/mainwindow_ui_reach.py  | 83 +++++++++++------------
 src/View/InitialConditions/translate.py   |  4 +-
 src/View/SedimentLayers/Edit/translate.py |  2 +-
 7 files changed, 51 insertions(+), 58 deletions(-)

diff --git a/src/Model/Stricklers/Stricklers.py b/src/Model/Stricklers/Stricklers.py
index baa484fa..a5670d21 100644
--- a/src/Model/Stricklers/Stricklers.py
+++ b/src/Model/Stricklers/Stricklers.py
@@ -38,7 +38,7 @@ class Stricklers(SQLSubModel):
         else:
             self.id = id
 
-        Stricklers._id_cnt = max(Stricklers._id_cnt + 1, self.id)
+        Stricklers._id_cnt = max(Stricklers._id_cnt + 1, id + 1)
 
         self._name = name
         self._comment = comment
diff --git a/src/View/BoundaryCondition/translate.py b/src/View/BoundaryCondition/translate.py
index c4ff8f88..172999a7 100644
--- a/src/View/BoundaryCondition/translate.py
+++ b/src/View/BoundaryCondition/translate.py
@@ -29,9 +29,9 @@ _translate = QCoreApplication.translate
 long_types = {
     "ND": _translate("BoundaryCondition", "Not defined"),
     "PC": _translate("BoundaryCondition", "Ponctual contribution"),
-    "TZ": _translate("BoundaryCondition", "Time over Z"),
-    "TD": _translate("BoundaryCondition", "Time over Discharge"),
-    "ZD": _translate("BoundaryCondition", "Z over Discharge"),
+    "TZ": _translate("BoundaryCondition", "TimeZ"),
+    "TD": _translate("BoundaryCondition", "TimeDischarge"),
+    "ZD": _translate("BoundaryCondition", "ZDischarge"),
     "SL": _translate("BoundaryCondition", "Solid"),
 }
 
diff --git a/src/View/Geometry/PlotAC.py b/src/View/Geometry/PlotAC.py
index fe6d933f..e43f39e9 100644
--- a/src/View/Geometry/PlotAC.py
+++ b/src/View/Geometry/PlotAC.py
@@ -67,18 +67,18 @@ class PlotAC(APlot):
         gl = self.data.profile(selected_profile).names()
 
         self.canvas.axes.set_xlabel(
-            _translate("MainWindow_reach", "Abscisse en travers (m)"),
+            _translate("MainWindow_reach", "Transverse abscissa (m)"),
             color='green', fontsize=12
         )
         self.canvas.axes.set_ylabel(
-            _translate("MainWindow_reach", "Cote (m)"),
+            _translate("MainWindow_reach", "Height (m)"),
             color='green', fontsize=12
         )
         self.canvas.figure.tight_layout()
 
-        label_before_plot_selected = _translate("MainWindow_reach", "Profil précédent")
-        label_plot_selected = _translate("MainWindow_reach", "Profil sélectionné")
-        label_after_plot_selected = _translate("MainWindow_reach", "Profil suivant")
+        label_before_plot_selected = _translate("MainWindow_reach", "Previous cross-section")
+        label_plot_selected = _translate("MainWindow_reach", "Cross-section")
+        label_after_plot_selected = _translate("MainWindow_reach", "Next cross-section")
         color_before_plot_selected = "k"  # 'grey'
         color_plot_selected = 'b'
         color_after_plot_selected = 'm'
diff --git a/src/View/Geometry/Window.py b/src/View/Geometry/Window.py
index 7776d737..1c8cb5da 100644
--- a/src/View/Geometry/Window.py
+++ b/src/View/Geometry/Window.py
@@ -111,7 +111,7 @@ class GeometryWindow(ASubMainWindow, ListedSubWindow):
         self.ui.btn_sort_desc.triggered.connect(self.sort_descending)
         self.ui.btn_move_up.triggered.connect(self.move_row_up)
         self.ui.btn_move_down.triggered.connect(self.move_row_down)
-        self.ui.btn_end_editing.triggered.connect(self.handleSave)
+        # self.ui.btn_end_editing.triggered.connect(self.handleSave)
         self.ui.btn_add.triggered.connect(self.insert_row)
         self.ui.btn_delete.triggered.connect(self.delete_rows)
         self.ui.btn_edit.triggered.connect(self.edit_profile)
diff --git a/src/View/Geometry/mainwindow_ui_reach.py b/src/View/Geometry/mainwindow_ui_reach.py
index 897b6987..60bcfa6e 100644
--- a/src/View/Geometry/mainwindow_ui_reach.py
+++ b/src/View/Geometry/mainwindow_ui_reach.py
@@ -95,29 +95,29 @@ class Ui_MainWindow(object):
         self.btn_edit.setIcon(icon_btn_edit)
         self.toolBar.addAction(self.btn_edit)
 
-        self.btn_copy_selected_profile = QtWidgets.QAction(self.widget)
-        self.btn_copy_selected_profile.setObjectName("btn_copy_selected_profile")
-        icon_btn_copy_selected_profile = QtGui.QIcon()
-        icon_btn_copy_selected_profile.addPixmap(
-            QtGui.QPixmap(f"{icon_path}gtk-copy.png"))
-        self.btn_copy_selected_profile.setIcon(icon_btn_copy_selected_profile)
-        self.toolBar.addAction(self.btn_copy_selected_profile)
-
-        self.btn_paste_selected_profile = QtWidgets.QAction(self.widget)
-        self.btn_paste_selected_profile.setObjectName("btn_paste_selected_profile")
-        icon_btn_paste_selected_profile = QtGui.QIcon()
-        icon_btn_paste_selected_profile.addPixmap(
-            QtGui.QPixmap(f"{icon_path}gtk-paste.png"))
-        self.btn_paste_selected_profile.setIcon(icon_btn_paste_selected_profile)
-        self.toolBar.addAction(self.btn_paste_selected_profile)
-
-        self.btn_duplicate_selected_profile = QtWidgets.QAction(self.widget)
-        self.btn_duplicate_selected_profile.setObjectName("btn_duplicate_selected_profile")
-        icon_btn_duplicate_selected_profile = QtGui.QIcon()
-        icon_btn_duplicate_selected_profile.addPixmap(
-            QtGui.QPixmap(f"{icon_path}gtk-dnd-multiple.png"))
-        self.btn_duplicate_selected_profile.setIcon(icon_btn_duplicate_selected_profile)
-        self.toolBar.addAction(self.btn_duplicate_selected_profile)
+        # self.btn_copy_selected_profile = QtWidgets.QAction(self.widget)
+        # self.btn_copy_selected_profile.setObjectName("btn_copy_selected_profile")
+        # icon_btn_copy_selected_profile = QtGui.QIcon()
+        # icon_btn_copy_selected_profile.addPixmap(
+        #     QtGui.QPixmap(f"{icon_path}gtk-copy.png"))
+        # self.btn_copy_selected_profile.setIcon(icon_btn_copy_selected_profile)
+        # self.toolBar.addAction(self.btn_copy_selected_profile)
+
+        # self.btn_paste_selected_profile = QtWidgets.QAction(self.widget)
+        # self.btn_paste_selected_profile.setObjectName("btn_paste_selected_profile")
+        # icon_btn_paste_selected_profile = QtGui.QIcon()
+        # icon_btn_paste_selected_profile.addPixmap(
+        #     QtGui.QPixmap(f"{icon_path}gtk-paste.png"))
+        # self.btn_paste_selected_profile.setIcon(icon_btn_paste_selected_profile)
+        # self.toolBar.addAction(self.btn_paste_selected_profile)
+
+        # self.btn_duplicate_selected_profile = QtWidgets.QAction(self.widget)
+        # self.btn_duplicate_selected_profile.setObjectName("btn_duplicate_selected_profile")
+        # icon_btn_duplicate_selected_profile = QtGui.QIcon()
+        # icon_btn_duplicate_selected_profile.addPixmap(
+        #     QtGui.QPixmap(f"{icon_path}gtk-dnd-multiple.png"))
+        # self.btn_duplicate_selected_profile.setIcon(icon_btn_duplicate_selected_profile)
+        # self.toolBar.addAction(self.btn_duplicate_selected_profile)
 
         self.btn_sort_asc = QtWidgets.QAction(self.widget)
         self.btn_sort_asc.setObjectName("btn_sort_asc")
@@ -151,13 +151,13 @@ class Ui_MainWindow(object):
         self.btn_move_down.setIcon(icon_btn_move_down)
         self.toolBar.addAction(self.btn_move_down)
 
-        self.btn_end_editing = QtWidgets.QAction(self.widget)
-        self.btn_end_editing.setObjectName("btn_end_editing")
-        icon_btn_save = QtGui.QIcon()
-        icon_btn_save.addPixmap(
-            QtGui.QPixmap(f"{icon_path}gtk-apply.png"))
-        self.btn_end_editing.setIcon(icon_btn_save)
-        self.toolBar.addAction(self.btn_end_editing)
+        # self.btn_end_editing = QtWidgets.QAction(self.widget)
+        # self.btn_end_editing.setObjectName("btn_end_editing")
+        # icon_btn_save = QtGui.QIcon()
+        # icon_btn_save.addPixmap(
+        #     QtGui.QPixmap(f"{icon_path}gtk-apply.png"))
+        # self.btn_end_editing.setIcon(icon_btn_save)
+        # self.toolBar.addAction(self.btn_end_editing)
 
         self.verticalLayout.addLayout(self.horizontalLayout)
         self.tableView = QtWidgets.QTableView(self.widget)
@@ -314,30 +314,23 @@ class Ui_MainWindow(object):
     def retranslateUi(self, MainWindow_reach):
         _translate = QtCore.QCoreApplication.translate
         self.name_reach = ""
-        self.mainwindow_title = _translate("MainWindow_reach", "Jeu de sections du Bief")
+        self.mainwindow_title = _translate("MainWindow_reach", "Geometry reach edit")
         MainWindow_reach.setWindowTitle(self.mainwindow_title + f"{self.name_reach}")
-        self.text_section_order = _translate("MainWindow_reach", "\nOrdre des sections : "
-                                                                 "Amont --> Aval")
         # self.label_section_order.setText(f"{self.text_section_order}")
         self.vertical_slider_value = ""
-        self.vertical_slider_label.setText(_translate("MainWindow_reach", "Pk = ") + f"{self.vertical_slider_value}")
-        self.btn_open.setToolTip(_translate("MainWindow_reach", " Importer une géométrie"))
-        self.btn_add.setToolTip(_translate("MainWindow_reach", " Nouveau profil"))
-        self.btn_delete.setToolTip(_translate("MainWindow_reach", " Supprimer le profil sélectionné"))
-        self.btn_edit.setToolTip(_translate("MainWindow_reach", " Éditer le profil sélectionné"))
-        self.btn_copy_selected_profile.setToolTip(_translate("MainWindow_reach", " Copier le profil sélectionné"))
-        self.btn_paste_selected_profile.setToolTip(_translate("MainWindow_reach", "Coller le profil en fin de liste ("
-                                                                                  "penser à modifier le Pk avant de "
-                                                                                  "trier)"))
-        self.btn_duplicate_selected_profile.setToolTip(
-            _translate("MainWindow_reach", " Dupliquer la section sélectionnée"))
+        self.vertical_slider_label.setText(_translate("MainWindow_reach", "Kp = ") + f"{self.vertical_slider_value}")
+        self.btn_open.setToolTip(_translate("MainWindow_reach", " Import geometry"))
+        self.btn_add.setToolTip(_translate("MainWindow_reach", " New profile"))
+        self.btn_delete.setToolTip(_translate("MainWindow_reach", " Delete selected profile"))
+        self.btn_edit.setToolTip(_translate("MainWindow_reach", " Editer selected profile"))
+
         self.btn_sort_asc.setToolTip(_translate("MainWindow_reach", " Trier les profils par ordre croissant des Pk"))
         self.btn_sort_desc.setToolTip(_translate("MainWindow_reach", " Trier les profils par ordre décroissant des Pk"))
         self.btn_move_up.setToolTip(_translate("MainWindow_reach", " Changer l'ordre des profils (en décalant le "
                                                                    "profil sélectionné vers le haut)"))
         self.btn_move_down.setToolTip(_translate("MainWindow_reach", " Changer l'ordre des profils (en décalant le "
                                                                      "profil sélectionné vers le bas)"))
-        self.btn_end_editing.setToolTip(_translate("MainWindow_reach", " Terminer l'édition"))
+        # self.btn_end_editing.setToolTip(_translate("MainWindow_reach", " Terminer l'édition"))
         self.tableView_header = [_translate("MainWindow_reach", "Name"),
                                  _translate("MainWindow_reach", "Kp (m)"),
                                  _translate("MainWindow_reach", "Type")]
diff --git a/src/View/InitialConditions/translate.py b/src/View/InitialConditions/translate.py
index 370d4a22..3fe45f75 100644
--- a/src/View/InitialConditions/translate.py
+++ b/src/View/InitialConditions/translate.py
@@ -21,11 +21,11 @@ from PyQt5.QtCore import QCoreApplication
 _translate = QCoreApplication.translate
 
 table_headers = {
-    "name": _translate("LateralContribution", "Name"),
+    # "name": _translate("LateralContribution", "Name"),
     "kp": _translate("LateralContribution", "KP (m)"),
     # "speed": _translate("LateralContribution", "Speed (m/s)"),
     "discharge": _translate("LateralContribution", "Discharge (m³/s)"),
     "elevation": _translate("LateralContribution", "Elevation (m)"),
     "height": _translate("LateralContribution", "Height (m)"),
-    "comment": _translate("LateralContribution", "Comment"),
+    # "comment": _translate("LateralContribution", "Comment"),
 }
diff --git a/src/View/SedimentLayers/Edit/translate.py b/src/View/SedimentLayers/Edit/translate.py
index fe9e44a9..f9f02cbf 100644
--- a/src/View/SedimentLayers/Edit/translate.py
+++ b/src/View/SedimentLayers/Edit/translate.py
@@ -6,7 +6,7 @@ _translate = QCoreApplication.translate
 
 table_headers = {
     "name": _translate("SedimentLayers", "Name"),
-    "type": _translate("SedimentLayers", "Type"),
+    # "type": _translate("SedimentLayers", "Type"),
     "height": _translate("Sedimentlayers", "Height"),
     "d50": _translate("Sedimentlayers", "D50"),
     "sigma": _translate("Sedimentlayers", "Sigma"),
-- 
GitLab