Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • airGR airGR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Redmine
    • Redmine
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • HYCAR-HydroHYCAR-Hydro
  • airGRairGR
  • Issues
  • #109
Closed
Open
Issue created Mar 16, 2021 by Dorchies David@david.dorchiesDeveloper

RunModel_Lag: Add an argument `QcontribDown` to `RunModel_Lag`

Currently, the runoff contribution of the downstream sub-basin is included in the InputsModelobject by copying the OutputsModel object of the GR simulation (extracted from RunModel_lag example script):

# Add the output of the precipitation-runoff model in the InputsModel object
InputsModel$OutputsModel <- OutputsModelDown

# Run the lag model which routes precipitation-runoff model and upstream flows
OutputsModel <- RunModel_Lag(InputsModel = InputsModel,
                             RunOptions = RunOptions, Param = Velocity)

This way of proceeding is:

  • ugly 😅
  • not generic if you want to inject another contribution than a GR model output
  • cumbersome because we don't need to copy all informations contained in OutputsModel, only Qsim

Using a new argument QcontribDown in RunModel_Lag for the runoff contribution of the downstream sub-basin would be cleaner and more generic.

Edited Mar 16, 2021 by Dorchies David
Assignee
Assign to
Time tracking