Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • airGR airGR
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 64
    • Issues 64
    • List
    • Boards
    • Service Desk
    • Milestones
  • Redmine
    • Redmine
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

La forge institutionnelle d'INRAE étant en production depuis le 10 juin 2025, nous vous recommandons d'y créer tous vos nouveaux projets.

  • HYCAR-HydroHYCAR-Hydro
  • airGRairGR
  • Issues
  • #199
Closed
Open
Issue created Oct 06, 2025 by Delaigue Olivier@olivier.delaigueOwner

Decentralize criterion logic for easier extension of 'ErrorCrit' functions

Description

Currently, the logic for setting CritBestValue and Multiplier depending on the error criterion (e.g. RMSE, NSE, KGE, etc.) is handled inside the internal .ErrorCrit() function. This approach makes extensions and maintenance less generic, as new criteria would require central modification.

Proposal

Move the definition of CritBestValue and Multiplier to the individual criterion calculation functions: ErrorCrit_KGE, ErrorCrit_KGE2, ErrorCrit_NSE, and CreateErrorCrit_GAPX. This way, each function is responsible for its own logic regarding what constitutes a "best" value and the necessary multiplier.

Benefits

  • Improves modularity and extensibility, making it easier to add new error criteria without modifying the core logic
  • Reduces central conditional code and clarifies the purpose of each ErrorCrit_* function
Edited Oct 06, 2025 by Delaigue Olivier
Assignee
Assign to
Time tracking