Fix airGRteaching 0.2.9.25 reverse dependency
From: "Uwe Ligges"
Date: Jeudi 14 Janvier 2021 07:11:06
Subject: [CRAN-pretest-waiting] CRAN submission airGR 22.214.171.124
package airGR_126.96.36.199.tar.gz has been auto-processed. The auto-check found problems when checking the first order strong reverse dependencies.
Please reply-all and explain: Is this expected or do you need to fix anything in your package? If expected, have all maintainers of affected packages been informed well in advance? Are there false positives in our results?
*** Changes to worse in reverse dependencies ***
Log dir: https://win-builder.r-project.org/incoming_pretest/airGR_188.8.131.52_20210113_193646/
The files will be removed after roughly 7 days.
Pretests: Windows: https://win-builder.r-project.org/incoming_pretest/airGR_184.108.40.206_20210113_193646/Windows/00check.log
Changes to worse in reverse depends: Package: airGRteaching Check: R code for possible problems New result: NOTE plot.CalGR: no visible global function definition for "plot.OutputsModel" Undefined global functions or variables: plot.OutputsModel
If I understand well, even when airGRteaching is installed from sources, the package has registered the space from which the functions it depends on are exported.
|airGRteaching||0.2.9.25||yes||imported from the global environment|
|airGRteaching||0.2.10.106||to be submitted||imported from airGR namespace|
Using airGRteaching 0.2.9.25 (current version on the CRAN; it runs well on 0.2.10.106) with airGR 220.127.116.11:
plot(CAL) Error in plot.OutputsModel(x$OutputsModel, Qobs = x$Qobs, ...) : could not find function "plot.OutputsModel"
plot.OutputsModel() is currently call using
Although I answer to the CRAN team that the future version of airGRteaching will solve the problem, users with the 18.104.22.168 version of airGR and the 0.2.9.25 version of airGRteaching will not be able to use airGRteaching properly and we can't warn them). In order to avoid breaking the reverse dependency of airGRteaching, I suggest :
plot.OutputsModel()in airGR 1.6
airGR:::plot.OutputsModel()in airGRteaching 0.2.10
- not export
plot.OutputsModel()in in the next version of airGR (2.0)
plot()in the next version of airGRteaching (as it is used currently in the version 0.2.9.25)
I think the temporary use of
::: in airGRteaching will solve the transition smoothly for users and will help to avoid breaking airGRteaching.