Activity
changed milestone to %v1.6.10
added 1 commit
- a855db75 - ci: Extract regression tests from standard thestthat procedure
added 1 commit
- ca97d19c - ci: Extract regression tests from standard thestthat procedure
added 1 commit
- 30dbee89 - ci: Extract regression tests from standard thestthat procedure
added 1 commit
- 7f1e4f9c - test: Add exception in regression tests for RunModel_GR1A OutputsModel
added 1 commit
- cf5cac4c - ci: move regression_tests.R to testthat subdirectory to avoid execution by `R CMD CHECK`
assigned to @olivier.delaigue
I solved this issue by separating the regression test from the
R CMD CHECK
in commit 30dbee89. So here, the test failed as expected with this message (extracted from https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/jobs/131750):$ Rscript tests/regression_tests.R compare ══ Testing regression.R ════════════════════════════════════════════════════════ [ FAIL 1 | WARN 0 | SKIP 0 | PASS 555 ] ── FAILURE (regression.R:16:9): Compare RunModel_GR1A OutputsModel ───────────── `testVar` not equivalent to `refVar`. Component “PotEvap”: Mean relative difference: 0.6917171 Component “Precip”: Mean relative difference: 0.4088846 Component “StateEnd”: target is numeric, current is NULL [ FAIL 1 | WARN 0 | SKIP 0 | PASS 555 ] ERROR: Job failed: exit status 1
So now it detects the change that occurred in
RunModel_GR1A
.Because the tests should pass anyway, I added an item in the
.regressionignore
file in the commit 7f1e4f9c.Please keep in mind that when the new version of airGR will be released, we'll have to empty or remove the
.regressionignore
file in order to not skip these tests any more.So now, we're ready to merge
mentioned in commit 6cbced89