Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • A airGRdatassim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

La forge gitlab.irstea.fr sera définitivement arrêtée le 30 juin 2026. Nous vous invitons à migrer vos projets vers la forge INRAE. Vous trouverez plus de détails sur le blog de la forge INRAE.

  • HYCAR-HydroHYCAR-Hydro
  • airGRdatassim
  • Issues
  • #1
Closed
Open
Issue created Jun 09, 2020 by Thirel Guillaume@guillaume.thirel

Add new models

While allowing for the use of other models than GR5J is not a priority (but seems not that difficult), I would encourage you to allow for the use of CemaNeigeGR5J. @gaia.piazzi , I guess this would work and we don't necessarily need to perturb temperature, what do you think? What about using '...' to give the necessary arguments of CreateInputsModel for snow model?

In addition, I propose replacing this error message in CreateInputsPerturb:

stop("incorrect 'FUN_MOD' for use in 'MeteoPert'. Only 'RunModel_GR5J' can be used")

with

stop("incorrect 'FUN_MOD' for use in 'CreateInputsPerturb'. Only 'RunModel_GR5J' can be used")

Same in Run_ModelDA. Replace:

stop("incorrect 'FUN_MOD' for use in 'MeteoPert'. Only 'RunModel_GR5J' can be used")

with

stop("incorrect 'FUN_MOD' for use in 'RunModel_DA'. Only 'RunModel_GR5J' can be used")

Edited Nov 24, 2020 by Delaigue Olivier
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking