Commit 9e373de5 authored by unknown's avatar unknown
Browse files

v0.1.8.10 bug fixed in ShinyGR when imputs are defined in vectors (not in a data.frame)

Showing with 29 additions and 12 deletions
+29 -12
Package: airGRteaching Package: airGRteaching
Type: Package Type: Package
Title: Tools to Simplify the Use of the airGR Hydrological Package for Education (Including a Shiny Interface) Title: Tools to Simplify the Use of the airGR Hydrological Package for Education (Including a Shiny Interface)
Version: 0.1.8.9 Version: 0.1.8.10
Date: 2017-11-28 Date: 2017-11-28
Authors@R: c(person("Olivier", "Delaigue", role = c("aut", "cre"), email = "airGR@irstea.fr"), person("Laurent", "Coron", role = c("aut")), person("Pierre", "Brigode", role = c("aut")), person("Guillaume", "Thirel", role = c("ctb"))) Authors@R: c(person("Olivier", "Delaigue", role = c("aut", "cre"), email = "airGR@irstea.fr"), person("Laurent", "Coron", role = c("aut")), person("Pierre", "Brigode", role = c("aut")), person("Guillaume", "Thirel", role = c("ctb")))
Depends: airGR (>= 1.0.9.43) Depends: airGR (>= 1.0.9.43)
......
ShinyGR <- function(ObsBV = NULL, DatesR = NULL, Precip = NULL, PotEvap = NULL, Qobs = NULL, TempMean = NULL, ShinyGR <- function(ObsBV = NULL, DatesR = NULL, Precip = NULL, PotEvap = NULL, Qobs = NULL, TempMean = NULL,
ZInputs = NULL, HypsoData = NULL, NLayers = 5, SimPer = NULL, ZInputs = NULL, HypsoData = NULL, NLayers = 5, SimPer = NULL,
theme = "RStudio") { theme = "RStudio") {
if (is.null(ObsBV)) {
ObsBV <- "Unnamed watershed"
}
.GlobalEnv$.ShinyGR.hist <- list(list())#list(Param = list(), TypeModel = lsit(), Crit = list(), Qsim = list()) .GlobalEnv$.ShinyGR.hist <- list(list())#list(Param = list(), TypeModel = lsit(), Crit = list(), Qsim = list())
.GlobalEnv$.ShinyGR.args <- list(ObsBV = as.list(ObsBV), .GlobalEnv$.ShinyGR.args <- list(ObsBV = as.list(ObsBV),
......
...@@ -25,13 +25,20 @@ shinyServer(function(input, output, session) { ...@@ -25,13 +25,20 @@ shinyServer(function(input, output, session) {
if (input$SnowModel == "CemaNeige") { if (input$SnowModel == "CemaNeige") {
PARAM <- c(PARAM, input$C1, input$C2) PARAM <- c(PARAM, input$C1, input$C2)
} }
# if (input$Dataset == "Unnamed watershed") {
OBS <- ObsGR(ObsBV = get(input$Dataset), HydroModel = input$HydroModel, if (input$Dataset == "Unnamed watershed") {
CemaNeige = input$SnowModel == "CemaNeige", ObsBV <- NULL
Precip = .ShinyGR.args$Precip, PotEvap = .ShinyGR.args$PotEvap, } else {
Qobs = get(input$Dataset), TempMean = .ShinyGR.args$TempMean, ObsBV <- get(input$Dataset)
ZInputs = .ShinyGR.args$ZInputs, HypsoData = .ShinyGR.args$HypsoData, }
NLayers = .ShinyGR.args$NLayers) OBS <- ObsGR(ObsBV = ObsBV,
DatesR = .ShinyGR.args$DatesR,
Precip = .ShinyGR.args$Precip, PotEvap = .ShinyGR.args$PotEvap,
Qobs = .ShinyGR.args$Qobs, TempMean = .ShinyGR.args$TempMean,
ZInputs = .ShinyGR.args$ZInputs, HypsoData = .ShinyGR.args$HypsoData,
NLayers = .ShinyGR.args$NLayers,
HydroModel = input$HydroModel,
CemaNeige = input$SnowModel == "CemaNeige")
WUPPER <- c(OBS$InputsModel$DatesR[1L], input$Period[1]-.TypeModelGR(OBS)$TimeLag) WUPPER <- c(OBS$InputsModel$DatesR[1L], input$Period[1]-.TypeModelGR(OBS)$TimeLag)
if (WUPPER[2] < WUPPER[1]) { if (WUPPER[2] < WUPPER[1]) {
...@@ -190,12 +197,18 @@ shinyServer(function(input, output, session) { ...@@ -190,12 +197,18 @@ shinyServer(function(input, output, session) {
OBSold <- getPrep()$OBS OBSold <- getPrep()$OBS
OBSold$TypeModel <- .GlobalEnv$.ShinyGR.hist[[1]]$TypeModel OBSold$TypeModel <- .GlobalEnv$.ShinyGR.hist[[1]]$TypeModel
if (.TypeModelGR(OBSold)$CemaNeige & !.TypeModelGR(getPrep()$OBS)$CemaNeige) { # present: No CemaNeige ; old: CemaNeige if (.TypeModelGR(OBSold)$CemaNeige & !.TypeModelGR(getPrep()$OBS)$CemaNeige) { # present: No CemaNeige ; old: CemaNeige
OBSold <- ObsGR(ObsBV = get(input$Dataset), HydroModel = .TypeModelGR(OBSold)$NameModel, if (input$Dataset == "Unnamed watershed") {
CemaNeige = .TypeModelGR(OBSold)$CemaNeige, ObsBV <- NULL
} else {
ObsBV <- get(input$Dataset)
}
OBSold <- ObsGR(ObsBV = ObsBV,
Precip = .ShinyGR.args$Precip, PotEvap = .ShinyGR.args$PotEvap, Precip = .ShinyGR.args$Precip, PotEvap = .ShinyGR.args$PotEvap,
Qobs = get(input$Dataset), TempMean = .ShinyGR.args$TempMean, Qobs = .ShinyGR.args$Qobs, TempMean = .ShinyGR.args$TempMean,
ZInputs = .ShinyGR.args$ZInputs, HypsoData = .ShinyGR.args$HypsoData, ZInputs = .ShinyGR.args$ZInputs, HypsoData = .ShinyGR.args$HypsoData,
NLayers = .ShinyGR.args$NLayers) NLayers = .ShinyGR.args$NLayers,
HydroModel = input$HydroModel,
CemaNeige = input$SnowModel == "CemaNeige")
} }
SIMold <- SimGR(ObsGR = OBSold, SIMold <- SimGR(ObsGR = OBSold,
Param = .GlobalEnv$.ShinyGR.hist[[1]]$Param, Param = .GlobalEnv$.ShinyGR.hist[[1]]$Param,
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment