Commit 144f3510 authored by Thibault Hallouin's avatar Thibault Hallouin
Browse files

fix error in ROCSS computation

Showing with 3 additions and 1 deletion
+3 -1
...@@ -514,7 +514,9 @@ namespace evalhyd ...@@ -514,7 +514,9 @@ namespace evalhyd
{ {
// compute the area under the ROC curve // compute the area under the ROC curve
// xt::trapz(y, x, axis=4) // xt::trapz(y, x, axis=4)
auto A = xt::trapz(POD, POFD, 4); // (note: taking the opposite of the integration results
// because POD/POFD values are in decreasing order)
auto A = - xt::trapz(POD, POFD, 4);
// compute the ROC skill score // compute the ROC skill score
// $SS_{ROC} = \frac{A - A_{random}}{A_{perfect} - A_{random}}$ // $SS_{ROC} = \frac{A - A_{random}}{A_{perfect} - A_{random}}$
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment