[CreateInputsModel] Make `Qobs` parameter optional
The Qobs parameter is useless when the network in only composed of hydrological model nodes.
Qobs is used to fill the matrix Qupstream parameter of airGR::CreateInputsModel items but the column of this matrix is replace by upstream simulated flows during calibration and simulation.
The only exception are:
- when direct flows are injected in the network (case
model = NA). - when using option
useUpstreamQsim = FALSEinCalibration
So my proposition is that:
-
Qobsshould be optional and in that case,Qupstreamshould be filled with zeros forairGR::CreateInputsModelcalls. -
Qobsis mandatory only in case of nodes withmodel = NAand column names should at least match with these nodes. - In case of using option
useUpstreamQsim = FALSE, check inCalibrationthat all nodes are present in the columns.