Add test using calibration algorithm with all models
Add test using calibration algorithm with all models
GR4J is currently the only model tested using the calibration algorithm. It might be a good idea to test the other models with calibrations, even if they are tested with simulations.
Activity
- Delaigue Olivier changed milestone to %v1.7.0
changed milestone to %v1.7.0
- Delaigue Olivier added SUGGESTION label
added SUGGESTION label
- Delaigue Olivier added 1 deleted label
added 1 deleted label
- Delaigue Olivier removed 1 deleted label
removed 1 deleted label
- Delaigue Olivier added TEST & CI/CD label
added TEST & CI/CD label
- Dorchies David assigned to @david.dorchies
assigned to @david.dorchies
- Dorchies David mentioned in issue #124
mentioned in issue #124
- Dorchies David created merge request !48 (merged) to address this issue
created merge request !48 (merged) to address this issue
- Dorchies David mentioned in merge request !48 (merged)
mentioned in merge request !48 (merged)
- Dorchies David mentioned in commit 1dc1fd5f
mentioned in commit 1dc1fd5f
- Dorchies David mentioned in commit db303278
mentioned in commit db303278
- Dorchies David mentioned in commit 7a97389c
mentioned in commit 7a97389c
- Dorchies David mentioned in commit eaeff017
mentioned in commit eaeff017
- Developer
I have implemented tests for all combinations of models (GR1A, GR2M, GR4J, GR5J, GR6J, GR4H, GR5H) and all possibilities with Cemaneige with and without hysteresis (total 17 calibrations).
This test takes 22 minutes... It will not be run on CRAN but anyway it's quite long for our CI process which now takes 32 minutes instead of 10. Is it possible to reduce the time computation by for example reduce the accuracy of the criteria?
Edited by Dorchies David - Owner
Unfortunately, it is not possible to play with the convergence of the parameter optimisation. The best way to reduce the duration of such a test is to reduce the length of the calibration period.
- Author Owner
Isn't it possible to run this task only once a week?
- Developer
Yes, like the regression tests which are run separately.
- Please register or sign in to reply
- Dorchies David mentioned in commit eaf8e83b
mentioned in commit eaf8e83b
- Dorchies David mentioned in commit d041d103
mentioned in commit d041d103
- Dorchies David mentioned in commit 89353dd1
mentioned in commit 89353dd1
- Delaigue Olivier mentioned in commit 82a929a6
mentioned in commit 82a929a6
- Delaigue Olivier mentioned in commit 267ee1b7
mentioned in commit 267ee1b7
- Delaigue Olivier closed via merge request !48 (merged)
closed via merge request !48 (merged)