Opening of usable functions in SeriesAggreg

"min", "max" and "median" should be usable besides "sum" and "mean" functions currently available in SeriesAggreg. But also other functions as below:

Quantile (percentile)

A call to a function named "qn" should be interpreted as quantile(x, probs = n) (i.e. "q90" as probs = 0.9)

Any function

Any function taking a vector as first argument and returning a single value.

changed milestone to %v1.6.10

added ENHANCEMENT label

changed title from Add "min", "max", and "median" function in SeriesAggreg to Opening of usable functions in SeriesAggreg

changed the description

For internal percentile implementation, @olivier.delaigue proposes:

ConvertFun <- "q090"
ConvertFun <- tolower(ConvertFun)
patternQuant <- "(^q)(\\d$)"
test1 <- grepl(PatternQuant, ConvertFun)
if (test1) {
  probs <- as.numeric(gsub(patternQuant, "\\2", ConvertFun)) / 100
  test2 <- probs >= 0 && probs <= 1
}
if (test2) {
  ConvertFunQuant <- quantile(x, probs = probs)
}

assigned to @david.dorchies

created merge request !25 (merged) to address this issue

mentioned in merge request !25 (merged)

added R label

First implementation in 192931c7 without internal implementation of quantile.

I think there is an ambiguity in the treatment of embedded lists.

I propose that:

• if length(ConvertFun)==1 then the same function is applied to all item en item in sub lists.
• else if any(class(x) %in% c("InputsModel", "OutputsModel") then ConvertFun = .GetAggregConvertFun...
• else error "ConvertFun must be of length 1"

It's a bit restrictive but I think it's less hazardous than allowing a vector a function corresponding to ordered numeric items in the list which can be mixed with other objects (data.frame, sublists...).

I'm a bit sorry to put a condition in SeriesAggreg.list relative to "InputsModel" and "OutputsModel" classes but the other solution would be to rewrite in each method an algorithm for exploring embedded lists which is not clean either.

mentioned in commit 8ef0f0de

mentioned in commit 605e6c2f

mentioned in commit d505a801

closed via merge request !25 (merged)

mentioned in commit 82d79290

closed via commit d505a801

mentioned in commit fa26d189

mentioned in commit 7b427cce