Resolve "Gitlab-CI: correctly handle WARNING and NOTE in checks"

Closes #86 (closed)

changed milestone to %v1.6.11

added Doing ENHANCEMENT labels

added 1 commit

• cb03eda3 - ci: checks with warning should fail

Compare with previous version

added 1 commit

• ac915da3 - ci: dependencies issue

Compare with previous version

added 1 commit

• d712248f - ci: dependencies issue with package 'usethis'

Compare with previous version

added 1 commit

• 355898b3 - ci: dependencies issue with package 'usethis'

Compare with previous version

added 1 commit

• 8ca348c0 - ci: dependencies issue with package 'usethis'

Compare with previous version

added 1 commit

• 2260f61a - ci: dependencies issue with package 'usethis'

Compare with previous version

added 1 commit

• 955afb44 - fix(RunModel): documentation of argument "..." in RunModel and Calibration

Compare with previous version

added 1 commit

• 7fda30e5 - ci: case sensitive issue on airGR.check folder

Compare with previous version

added 1 commit

• 8fdbce02 - ci: redefine check "as cran" and "not cran"

Compare with previous version

added 1 commit

• 5a7d7d9d - ci: test revdepcheck test

Compare with previous version

added 1 commit

• 959e1eb7 - ci(revdepcheck): add artifacts for browsing report documents after the job

Compare with previous version

added 1 commit

• a1524242 - ci(revdepcheck): Reverse dependency check only performs on schedules and tags

Compare with previous version

assigned to @olivier.delaigue and unassigned @david.dorchies

marked this merge request as ready

Hi @olivier.delaigue

I opened this MR because of a warning check that was not revealed after #108 (closed).

So I started first to solve this issue of false positive test in order to get a failed job when a warning is encountered in the R check. I then solved the documentation issue with #108 (closed) and, finally, I have implemented the reverse dependency checking which is triggered on scheduled jobs and when a tag is created. It seems that it's working pretty well

If you are OK, I kindly ask you to merge this branch into devel so that I can finish my task on #110 (closed)...

removed Doing label

mentioned in issue #110 (closed)

marked this merge request as draft

See #110 (comment 37315) for details about the newly draft status.

marked this merge request as ready

added 11 commits

• a1524242...db128c87 - 10 commits from branch dev
• 03ecb8d2 - Merge branch 'dev' into '86-gitlab-ci-correctly-handle-warning-and-note-in-checks'

Compare with previous version

added 2 commits

• 2a993dad - 1 commit from branch dev
• 58e6bb68 - Merge branch 'dev' into '86-gitlab-ci-correctly-handle-warning-and-note-in-checks'

Compare with previous version

The check crashes with this message:

> if (length(devtools::check_failures(path = Sys.getenv("BUILD_LOGS_DIR"), note = FALSE)) > 0) stop()
Erreur : 'check_failures' n'est pas un objet exporté depuis 'namespace:devtools'
Exécution arrêtée

Really? WTF!

I have seen. Has the version of R changed on the CI?

Nope. Nothing has changed. But it really seems to be an issue with the R version installed on the server.

I'm currently updating "patched version" because it still was v4.0.0 that I had compiled myself last year. I added the cran repository on my debian and update to v4.0.5 to not depend on a compiled version of R from source which is always a real challenge to manage...

I keep you in touch.

Something also seems to have affected airGRdatassim.

I said bullshit, airGRdatassim CI runs on the Lyon's runner...

Found why in https://cran.r-project.org/web/packages/devtools/news/news.html:

devtools 2.4.0

Breaking changes and deprecated functions

The check_results() function has been removed. It was not used by any CRAN package, and much better alternatives are available in the rcmdcheck package.

I'm searching for an alternative in rcmdcheck package...

I really didn't need that at this moment...

Temporarily, the easiest way is probably to install the previous version of 'devtools' on the server, isn't it?

It seems that I have solved this issue (and by the way again simplified the CI process): https://gitlab.irstea.fr/HYCAR-Hydro/airgr/-/commits/86-gitlab-ci-correctly-handle-warning-and-note-in-checks/.gitlab-ci.yml

Like the French people say: "Encore une victoire de canard!"

added 1 commit

• b131e890 - fix(ci): check_results() function has been removed from devtools package

Compare with previous version

added 1 commit

• 1009456f - ci: debug R_LIBS_USER issue with R v4.0.5

Compare with previous version

added 1 commit

• 20467dc6 - ci: debug R_LIBS_USER issue with R v4.0.5

Compare with previous version

added 1 commit

• 7fa5af84 - fix(ci): libPaths issue with R v4.0.5

Compare with previous version

added 1 commit

• d0931353 - fix(ci): libPaths issue with R v4.0.5

Compare with previous version

added 1 commit

• b0ad6d6f - fix(ci): libPaths issue with R v4.0.5

Compare with previous version

merged

mentioned in commit a70d4704