Resolve "Optimisation of OutputsModel creation in RunModel*"

Closes #129 (closed)

changed milestone to %v1.7.0

added ENHANCEMENT label

added 3 commits

• 078e10a4 - feat: move creation of FortranOutputs from RunModel to RunOptions
• 23a72185 - feat: test the use of common function `.GetOutputsModel` on GR4J
• 329591eb - ci: temporary switch on scheduled tests for full tests

Compare with previous version

added 1 commit

• 0ada9d71 - feat: use .GetOutputsModel for all RunModel functions

Compare with previous version

added 1 commit

• 4156920f - test: add .regressionignore for all RunOptions

Compare with previous version

added 2 commits

• 8431b150 - doc(vignettes): mispelled word
• 29dec7ea - refactor(RunModel_*GR*): argument check with the function .ArgumentsCheckGR

Compare with previous version

added 1 commit

• 281beea5 - ci: switch off scheduled tests (back to normal)

Compare with previous version

added 1 commit

• 9fc9400b - refactor: rename .GetOutputsModel to .GetOutputsModelGR

Compare with previous version

assigned to @olivier.delaigue and unassigned @david.dorchies

marked this merge request as ready

I go further than expected, I have also optimised the argument checks.

The really really goood news is that I have removed 502 lines of code!

I've done a revdepcheck which is also OK:

> revdepcheck::revdep_check(num_workers = 2)
-- INSTALL ------------------------------------------------------------------------------------------ 2 versions --
Installing CRAN version of airGR
package ‘airGR’ successfully unpacked and MD5 sums checked
Installing DEV version of airGR
-- CHECK -------------------------------------------------------------------------------------------- 3 packages --
√ airGRdatassim 0.1.3                    -- E: 0     | W: 0-1   | N: 0                                             
√ airGRteaching 0.2.11                   -- E: 0     | W: 0-1   | N: 0                                             
√ baseflow 0.13.2                        -- E: 0     | W: 0     | N: 0                                             
OK: 3                                                                                                            
BROKEN: 0
Total time: 4 min

added 1 commit

• 08129fd4 - style: indent RunModel* codes

Compare with previous version

added 1 commit

• 95154f77 - style: indent RunModel* codes

Compare with previous version

mentioned in merge request !49 (merged)

merged

mentioned in commit f22f1a98