fix mistake in computation of CRPS_FROM_ECDF

include/evalhyd/detail/probabilist/cdf.hpp

@@ -107,16 +107,17 @@ namespace evalhyd
                 );
 
                 // compute crps as difference between the quadratic CDFs
-                auto p_i_2 = xt::eval(
+                auto p_i = xt::eval(
                         xt::view(
-                                xt::square(xt::arange<double>(n_mbr + 1) / n_mbr),
+                                xt::arange<double>(n_mbr + 1) / n_mbr,
                                 xt::all(), xt::newaxis(), xt::newaxis(),
                                 xt::newaxis()
                         )
                 );
 
                 auto crps_from_ecdf = xt::sum(
-                        (alpha_i * p_i_2) + (beta_i * (1 - p_i_2)),
+                        (alpha_i * xt::square(p_i))
+                        + (beta_i * xt::square(1 - p_i)),
                         0
                 );
 

tests/expected/evalp/CRPS_FROM_ECDF.csv

-271.9578705197483
+262.615225902479