Commit fff30851 authored by Thibault Hallouin's avatar Thibault Hallouin
Browse files

fix mistake in calculation of CRPS

No related merge requests found
Pipeline #39031 passed with stages
in 3 minutes and 32 seconds
Showing with 2 additions and 2 deletions
+2 -2
...@@ -90,7 +90,7 @@ namespace evalhyd ...@@ -90,7 +90,7 @@ namespace evalhyd
// integrate with trapezoidal rule // integrate with trapezoidal rule
crps = xt::view( crps = xt::view(
// xt::trapz(y, dx=1/(n+1), axis=0) // xt::trapz(y, dx=1/(n+1), axis=0)
xt::trapz(qs, 1./(double(n_mbr) + .1), 0), xt::trapz(qs, 1./(double(n_mbr) + 1.), 0),
xt::newaxis(), xt::all() xt::newaxis(), xt::all()
); );
} }
......
...@@ -115,7 +115,7 @@ TEST(ProbabilistTests, TestQuantiles) ...@@ -115,7 +115,7 @@ TEST(ProbabilistTests, TestQuantiles)
// Continuous ranked probability scores // Continuous ranked probability scores
xt::xtensor<double, 3> crps = xt::xtensor<double, 3> crps =
{{{ 257.412129}}}; {{{252.956919}}};
EXPECT_TRUE(xt::allclose(metrics[1], crps)); EXPECT_TRUE(xt::allclose(metrics[1], crps));
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment