v1.3.2.4 BUG: check added for hourly data in PE_Oudin

a69f0b5b · Delaigue Olivier · 40ef0791 · a69f0b5b · a69f0b5b · a69f0b5b
Commit a69f0b5b authored 6 years ago by Delaigue Olivier
Hide whitespace changes
Inline Side-by-side

Showing

with 8 additions and 2 deletions
+8 -2
--- a/DESCRIPTION
+++ b/DESCRIPTION
 Package: airGR
 Type: Package
 Title: Suite of GR Hydrological Models for Precipitation-Runoff Modelling
-Version: 1.3.2.3
+Version: 1.3.2.4
 Date: 2019-05-22
 Authors@R: c(
  person("Laurent", "Coron", role = c("aut", "trl"), comment = c(ORCID = "0000-0002-1503-6204")),

--- a/NEWS.rmd
+++ b/NEWS.rmd
@@ -14,7 +14,7 @@ output:



-### 1.3.2.3 Release Notes (2019-05-22)
+### 1.3.2.4 Release Notes (2019-05-22)


 #### New features

--- a/R/PE_Oudin.R
+++ b/R/PE_Oudin.R
@@ -53,6 +53,12 @@ PE_Oudin <- function(JD, Temp,
  if (!(TimeStepOut %in% c("daily", "hourly"))) {
    stop("'TimeStepOut' must be one of \"daily\" or \"hourly\"")
  }
+  if (TimeStepIn == "daily") {
+    rleJD <- rle(JD)
+    if (any(rleJD$lengths != 1)) {
+      stop("each day must have only one identical value of julian days")
+    }
+  }
  
  
  ## ---------- hourly inputs aggregation