Clean the RunModel functions
Clean the RunModel functions
All the RunModel_* functions (except RunModel_CemaNeige) should be cleant. There are still many checks written on a single line, which is hard to read.
Activity
mentioned in issue #34 (closed)
For continuing the discussion initiated in #34 (comment 19811) about model chaining. I think we can take advantage of the S3 class paradigm used in the InputsModel object to get a very simple chaining model solution for one geographic entity.
I have written an Rmarkdown script demonstrating the general mechanism we can use for
RunModeland chaining models together:Please have look and tell me what you think about it.
marked this issue as related to #65 (closed)
The
RunModel_GR1A()function is cleaned Refs #65 (closed), !16 (merged)created merge request !17 (merged) to address this issue
mentioned in merge request !17 (merged)
mentioned in commit 89b022ca
mentioned in commit d0f3169f
mentioned in commit 9c282325
mentioned in commit 0bdd3706
mentioned in commit 5a131e5a
mentioned in commit c1e540b4
mentioned in commit eb0ad606
mentioned in commit 4453a6fa
mentioned in commit 29d64e4e
mentioned in commit ec27c27c
mentioned in commit 76da62f0
mentioned in commit 710ab8cf
mentioned in commit 82796c60
mentioned in commit b1db2ae8
mentioned in commit 66e954b2
mentioned in commit 2846934f
mentioned in commit 7dc82d29
mentioned in commit 7fb10e94
mentioned in commit fe6b36f4
mentioned in commit 987c8320
mentioned in commit 69f1e711
mentioned in commit 02de3917
mentioned in commit 81fb0b6c
closed via merge request !17 (merged)
mentioned in commit dffc8b9d
The style of the codes has been improved to facilitate readability. However, the codes still need to be simplified. As written above, it is necessary that the different functions call the same internal functions when the code is common in order to remove the code redundancies. The use of S3 will solve this problem.
changed milestone to %v1.6.10
